Re: [PATCH 1/4] x86/xen: Remove redundant config dependency on X86_LOCAL_APIC
Andrew Cooper <[email protected]> Wed, 5 Aug 2026 09:43:15 +0100
| Newsgroups | gmane.comp.emulators.xen.devel,gmane.linux.kernel |
|---|---|
| Message-ID | <[email protected]> |
On 05/08/2026 9:40 am, Jan Beulich wrote: > On 05.08.2026 10:37, Jan Beulich wrote: >> On 05.08.2026 10:21, Juergen Gross wrote: >>> CONFIG_XEN depends on CONFIG_X86_LOCAL_APIC already, so the dependency >>> of CONFIG_XEN_PVHVM on CONFIG_X86_LOCAL_APIC can be dropped. >>> >>> Signed-off-by: Juergen Gross <[email protected]> >> Reviewed-by: Jan Beulich <[email protected]> > Hmm, looking at patch 2 I wonder: Isn't it XEN's dependency which wants > dropping? XEN_PV shouldn't require X86_LOCAL_APIC, should it? In Linux terms, XEN_PV does need X86_LOCAL_APIC. While the PV guest doesn't have an APIC directly, other areas (parsing the ACPI tables, configuring device interrupts) require Linux to think it's on a normal APIC-like system. ~Andrew