Re: [PATCH 15/24] XSM/dummy: drop redundant return statements

"Daniel P. Smith" <[email protected]> Wed, 5 Aug 2026 18:40:24 -0400
Newsgroups gmane.comp.emulators.xen.devel
Message-ID <[email protected]>
On 7/28/26 9:20 AM, Jan Beulich wrote:
> They're meaningless when no value is returned.
> 
> Signed-off-by: Jan Beulich <[email protected]>
> 
> --- a/xen/include/xsm/dummy.h
> +++ b/xen/include/xsm/dummy.h
> @@ -123,9 +123,7 @@ static XSM_INLINE int xsm_set_system_act
>   
>   static XSM_INLINE void xsm_security_domaininfo(
>       struct domain *d, struct xen_domctl_getdomaininfo *info)
> -{
> -    return;
> -}
> +{}
>   
>   static XSM_INLINE int xsm_domain_create(
>       XSM_DEFAULT_ARG struct domain *d, uint32_t ssidref)
> @@ -187,9 +185,7 @@ static XSM_INLINE int xsm_alloc_security
>   }
>   
>   static XSM_INLINE void xsm_free_security_domain(struct domain *d)
> -{
> -    return;
> -}
> +{}
>   
>   #ifdef CONFIG_GRANT_TABLE
>   
> @@ -316,9 +312,7 @@ static XSM_INLINE int xsm_evtchn_interdo
>   }
>   
>   static XSM_INLINE void xsm_evtchn_close_post(struct evtchn *chn)
> -{
> -    return;
> -}
> +{}
>   
>   static XSM_INLINE int xsm_evtchn_send(
>       XSM_DEFAULT_ARG struct domain *d, struct evtchn *chn)
> @@ -349,9 +343,7 @@ static XSM_INLINE int xsm_alloc_security
>   
>   static XSM_INLINE void xsm_free_security_evtchns(
>       struct evtchn chn[], unsigned int nr)
> -{
> -    return;
> -}
> +{}
>   
>   static XSM_INLINE char *xsm_show_security_evtchn(
>       struct domain *d, const struct evtchn *chn)
> 

Acked-by: Daniel P. Smith <[email protected]>