Re: [PATCH v1 01/17] xen/riscv: manage IRQ_DISABLED flag in APLIC irq enable/disable callbacks
Baptiste Le Duc <[email protected]>
| Newsgroups | gmane.comp.emulators.xen.devel |
|---|---|
| Message-ID | <1786368748.8631fc262581453bbf619ec5b2062170.19febdfec57000e099@vates.tech> |
On Mon, 20 Jul 2026 18:01:59 +0200, Oleksii Kurochko <[email protected]> wrote: > desc->status is only set once during setup_irq(), but interrupts can be > enabled/disabled at runtime, so update it in the corresponding callbacks. > > For the purposes of the FENCE instruction, CSR read accesses are > classified as device input (I) and CSR write accesses as device output > (O), while the barriers used by spin locks (fence rw,rw) only order > normal memory accesses. An explicit wmb() (fence ow,ow) is therefore > added in aplic_irq_{enable,disable}() to order the desc->status update > with respect to the IMSIC CSR write. > > [...] Reviewed-by: Baptiste Le Duc <[email protected]> -- Baptiste Le Duc <[email protected]> -- Baptiste Le Duc | Vates XCP-ng Intern XCP-ng & Xen Orchestra - Vates solutions web: https://vates.tech