Re: [PATCH v1 03/17] xen/riscv: add missing APLIC register offsets, masks to asm/aplic.h
Baptiste Le Duc <[email protected]>
| Newsgroups | gmane.comp.emulators.xen.devel |
|---|---|
| Message-ID | <1786369533.8631fc262581453bbf619ec5b2062170.19febebe536000e099@vates.tech> |
> These definitions are required for correct decoding of APLIC MMIO > accesses and target configuration, and will be used by both the > physical and virtual APLIC implementations. > > No functional change is intended by this patch; it only centralises > hardware definitions that were previously missing. > > Co-developed-by: Romain Caritey <[email protected]> > Signed-off-by: Oleksii Kurochko <[email protected]> > > diff --git a/xen/arch/riscv/include/asm/aplic.h b/xen/arch/riscv/include/asm/aplic.h > index 07318aaac2..f22622b9a2 100644 > --- a/xen/arch/riscv/include/asm/aplic.h > +++ b/xen/arch/riscv/include/asm/aplic.h > @@ -15,6 +15,8 @@ > > #include <asm/imsic.h> > > +#define APLIC_REG_OFFSET_MASK 0x3fff _REG stands for memory-mapped control "region" as explained in spec? If yes, it'd be better to add a comment. -- Baptiste Le Duc <[email protected]> -- Baptiste Le Duc | Vates XCP-ng Intern XCP-ng & Xen Orchestra - Vates solutions web: https://vates.tech