Re: [PATCH v10 2/10] libs/guest: move batch_pfns into a separate structure

On 10/08/2026 11:30 am, Frediano Ziglio wrote:
> Preparation for a followup patch "libs/guest: allocate various migration
> arrays just once".
>
> Signed-off-by: Frediano Ziglio <[email protected]>
> Reviewed-by: Anthony PERARD <[email protected]>

Coverity thinks this change has memory corruption.  I have to admit that
I'm not completely sure why it's noticed now; possibly because now it
can see the size of batch_pfns[] where previously it couldn't

** CID 1700057:       Memory - corruptions  (OVERRUN)
/tools/libs/guest/xg_sr_save.c: 284           in add_to_batch()
_____________________________________________________________________________________________
*** CID 1700057:         Memory - corruptions  (OVERRUN)
/tools/libs/guest/xg_sr_save.c: 284             in add_to_batch()
278         int rc = 0;
279     
280         if ( ctx->save.nr_batch_pfns == MAX_BATCH_SIZE )
281             rc = flush_batch(ctx);
282     
283         if ( rc == 0 )
>>>     CID 1700057:         Memory - corruptions  (OVERRUN)
>>>     Overrunning array "(*ctx).save.buffers->batch_pfns" of 1024 8-byte elements at element index 1024 (byte offset 8199) using index "(*ctx).save.nr_batch_pfns++" (which evaluates to 1024).
284             ctx->save.buffers->batch_pfns[ctx->save.nr_batch_pfns++] = pfn;
285     
286         return rc;
287     }
288     
289     /*


~Andrew