[PATCH] ARM/vgic: Clean up vgic_v2_setup_hw()
Andrew Cooper <[email protected]>
| Newsgroups | gmane.comp.emulators.xen.devel |
|---|---|
| Message-ID | <[email protected]> |
vgic_v2_setup_hw()'s callers are __init, so it should be too. vgic_v2_hw is written once during init and unmodified thereafter, so make it __ro_after_init. Reposition 'bool enabled' to fit in the tail padding, removing 8 bytes from the structure. No functional change. Signed-off-by: Andrew Cooper <[email protected]> --- CC: Stefano Stabellini <[email protected]> CC: Julien Grall <[email protected]> CC: Volodymyr Babchuk <[email protected]> CC: Bertrand Marquis <[email protected]> CC: Michal Orzel <[email protected]> Found when looking at the code while reviewing something else. Only compile tested. --- xen/arch/arm/vgic-v2.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/vgic-v2.c b/xen/arch/arm/vgic-v2.c index 642407fd5b05..3446d521de2d 100644 --- a/xen/arch/arm/vgic-v2.c +++ b/xen/arch/arm/vgic-v2.c @@ -25,7 +25,6 @@ #include <asm/vreg.h> static struct { - bool enabled; /* Distributor interface address */ paddr_t dbase; /* CPU interface address & size */ @@ -36,10 +35,12 @@ static struct { /* Offset to add to get an 8kB contiguous region if GIC is aliased */ uint32_t aliased_offset; -} vgic_v2_hw; + bool enabled; +} vgic_v2_hw __ro_after_init; -void vgic_v2_setup_hw(paddr_t dbase, paddr_t cbase, paddr_t csize, - paddr_t vbase, uint32_t aliased_offset) +void __init vgic_v2_setup_hw( + paddr_t dbase, paddr_t cbase, paddr_t csize, paddr_t vbase, + uint32_t aliased_offset) { vgic_v2_hw.enabled = true; vgic_v2_hw.dbase = dbase; base-commit: ebc00c30c65023bd1498ae20dc511c4e39f6c0f7 -- 2.39.5