Re: [PATCH 2/4] stubdom: remove pciutils

Jürgen Groß, le mar. 18 août 2026 07:43:34 +0200, a ecrit:
> On 17.08.26 18:37, Samuel Thibault wrote:
> > Juergen Gross, le lun. 17 août 2026 10:24:02 +0200, a ecrit:
> > > On 17.08.26 09:48, Samuel Thibault wrote:
> > > > Juergen Gross, le lun. 17 août 2026 09:18:41 +0200, a ecrit:
> > > > > There is no user of libpci left in stubdoms.
> > > > > 
> > > > > Remove libpci from the stubdom build system.
> > > > 
> > > > Wouldn't it be useful to keep this for anybody who would want to drive a
> > > > PCI card from a stubdomain?
> > > > 
> > > > I mean, in the zlib case, it's really a mere question of build & link,
> > > > so we don't need to ship it, people can do it themselves easily like for
> > > > any other library.
> > > > 
> > > > But here there is actual porting work, that we'd better not lose but
> > > > keep shipping.
> > > 
> > > This is all still available via git.
> > 
> > No, it is not really.
> > 
> > I keep reading this argument, but people will not know that something
> > exists in the git history, and will just assume that it does not exist
> > and has to be written.
> 
> What about adding a comment to the stubdom Makefile in a separate patch, like:
> 
> # pciutils support has been removed with commit <commit-id>, revert that patch
> # in case it is needed again.
> 
> I think this would be preferable over unused and probably bit-rotten code in
> the repository.

I don't see why it would be bit-rotten, since the pciutils version in
used is fixed, it's a library that has a quite stable API, and the pci
xen interface is supposed to keep backward compatibility.

Samuel