Re: [PATCH v2 1/2] xen/sched: core: skip missing vcpu slots in sched_move_domain()
Jan Beulich <[email protected]>
| Newsgroups | gmane.comp.emulators.xen.devel |
|---|---|
| Message-ID | <[email protected]> |
On 19.08.2026 07:15, Furkan Caliskan wrote:
> --- a/xen/common/sched/core.c
> +++ b/xen/common/sched/core.c
> @@ -745,6 +745,38 @@ int sched_move_domain(struct domain *d, struct cpupool *c)
>
> for ( unit_idx = 0; unit_idx < n_units; unit_idx++ )
> {
> + /*
> + * A vcpu slot can be missing if creation failed partway
> + * through. A dying domain is being torn down regardless, so
> + * skip the unit -- but a domain that isn't dying still needs
> + * every vcpu it has schedulable, so fail instead of silently
> + * dropping some of them.
> + */
> + bool vcpu_failed = false;
> +
> + for ( unsigned int i = 0;
> + i < gran && unit_idx * gran + i < d->max_vcpus; i++ )
> + {
> + if ( !d->vcpu[unit_idx * gran + i] )
Is there a particular reason domain_vcpu() cannot be used here?
Jan