Re: [PATCH v4 29/49] monitor: isolate HMP declarations in hmp.h

On 25/8/26 21:09, Marc-André Lureau wrote:
> Also rename password & commands with hmp in the name, while at it.
> Other functions need larger changes which we will take care of next.
> 
> Reviewed-by: Dr. David Alan Gilbert <[email protected]>
> Signed-off-by: Marc-André Lureau <[email protected]>
> ---
>   accel/accel-system.c           |  1 +
>   accel/tcg/monitor.c            |  1 +
>   chardev/char.c                 |  2 +-
>   disas/disas-mon.c              |  1 +
>   gdbstub/system.c               |  2 +-
>   hw/char/virtio-serial-bus.c    |  1 +
>   hw/core/machine-hmp-cmds.c     |  1 -
>   hw/core/sysbus.c               |  1 +
>   hw/hexagon/hexagon_tlb.c       |  1 +
>   hw/misc/auxbus.c               |  1 +
>   hw/usb/bus.c                   |  1 +
>   hw/usb/host-libusb.c           |  1 +
>   hw/xen/xen-bus.c               |  1 +
>   include/monitor/hmp.h          | 21 +++++++++++++++++++++
>   include/monitor/monitor.h      | 18 ------------------
>   monitor/hmp.c                  |  8 ++++----
>   monitor/monitor-internal.h     |  1 +
>   net/slirp.c                    |  1 +
>   stubs/monitor-core.c           |  1 +
>   stubs/monitor-internal.c       |  2 +-
>   target/rx/disas.c              |  1 +
>   tests/unit/test-util-sockets.c |  1 +
>   tools/qemu-vnc/stubs.c         |  1 +
>   trace/trace-hmp-cmds.c         |  1 -
>   ui/ui-hmp-cmds.c               |  4 ++--
>   util/error-report.c            |  2 +-
>   util/qemu-print.c              |  1 +
>   27 files changed, 48 insertions(+), 30 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <[email protected]>