[PATCH v2 11/39] xen/riscv: add helper to check APLIC MSI mode
Oleksii Kurochko <[email protected]>
| Newsgroups | gmane.comp.emulators.xen.devel |
|---|---|
| Message-ID | <a36ddb794b06ec9b7c470d9e665126989f4db58a.1787838835.git.oleksii.kurochko@gmail.com> |
Use convient helper instead of open-coding the things. Signed-off-by: Oleksii Kurochko <[email protected]> --- Changes in v2: - Rename helper. - Update the commit message. --- --- xen/arch/riscv/aplic.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/xen/arch/riscv/aplic.c b/xen/arch/riscv/aplic.c index 319a954f6f3c..b4c419755ac3 100644 --- a/xen/arch/riscv/aplic.c +++ b/xen/arch/riscv/aplic.c @@ -37,6 +37,11 @@ static struct intc_info __ro_after_init aplic_info = { .hw_variant = INTC_APLIC, }; +static bool aplic_msi_mode(void) +{ + return readl(&aplic.regs->domaincfg) & APLIC_DOMAINCFG_DM; +} + /* * The arrangement of IMSIC interrupt files in MMIO space follows a topology * defined by the RISC-V AIA specification. An IMSIC group is a set of @@ -250,7 +255,7 @@ static void cf_check aplic_irq_enable(struct irq_desc *desc) * If APLIC without MSI interrupts is required in the future, * this function will need to be updated accordingly. */ - ASSERT(readl(&aplic.regs->domaincfg) & APLIC_DOMAINCFG_DM); + ASSERT(aplic_msi_mode()); ASSERT(spin_is_locked(&desc->lock)); @@ -281,7 +286,7 @@ static void cf_check aplic_irq_disable(struct irq_desc *desc) * If APLIC without MSI interrupts is required in the future, * this function will need to be updated accordingly. */ - ASSERT(readl(&aplic.regs->domaincfg) & APLIC_DOMAINCFG_DM); + ASSERT(aplic_msi_mode()); ASSERT(spin_is_locked(&desc->lock)); -- 2.55.0