Re: [PATCH v2] ARM/vgic: Clean up vgic_v{2,3}_setup_hw()

Hi Michal,

On 28/08/2026 08:04, Michal Orzel wrote:
> From: Andrew Cooper <[email protected]>
> 
> vgic_v{2,3}_setup_hw()'s callers are __init, so they should be too.
> vgic_v{2,3}_hw and gic_v2_hw_data are written once during init and
> unmodified thereafter, so make them __ro_after_init.  Reposition
> 'bool enabled' in these structures to fit in the tail padding, removing
> 8 bytes from their size when paddr_t is 8B.
> 
> While at it, drop dead vgic_v3_setup_hw() dummy implementation
> from vgic/vgic.c. GICV3 depends on !NEW_VGIC.

I am not sure about this one. There are logics in the new vGIC which are 
GICv3 specific so technically not reachable. However, I would argue they 
should not be remove as the eventual goal as always been to move to a 
different GIC (our current vGIC is not spec compliant). For this 
specific change, it is easy to re-add so ...

> 
> No functional change.
> 
> Signed-off-by: Andrew Cooper <[email protected]>
> Signed-off-by: Michal Orzel <[email protected]>

Reviewed-by: Julien Grall <[email protected]>

Cheers,

-- 
Julien Grall