Re: makefile patches from MacPorts

Jeffrey Walton <[email protected]> writes:

>There's one more small issue here (if interested):
>
>    CFLAGS += -c -D__UNIX__ -DNDEBUG -I.
>
>By placing the library's CFLAGS after the user's CFLAGS, the library
>effectively overrides anything that conflicts.
>
>I think it should be the other way around: the user's CFLAGS are appended to
>the library's CFLAGS so the user's flags have precedence. We did the same in
>OWASP's ESAPI C++ so we did not step on user's CFLAGS/CXXFLAGS. See
>https://code.google.com/p/owasp-esapi-cplusplus/source/browse/trunk/GNUmakefile.

The problem is that this uses += again... the reason why the makefile calls
out to shell scripts is because that was the only way to do things in a
portable manner without lots of ugly hackery.  For example in the above
makefile there's extensive use of ifeq (and ifneq, and in general make-as-a-
scripting-language) that won't work with any generic make.

Peter.


_______________________________________________
Cryptlib mailing list
[email protected] via Mail: [email protected]
Archive: ftp://ftp.franken.de/pub/crypt/cryptlib/archives/
http://news.gmane.org/gmane.comp.encryption.cryptlib
Posts from non-subscribed addresses are blocked to prevent spam, please
subscribe in order to post messages.