Re: [PATCH gnupg] Fix gcc -Wunterminated-string-initialization warnings.

Collin Funk via Gnupg-devel <[email protected]> Wed, 30 Apr 2025 09:47:03 -0700

Newsgroups	gmane.comp.encryption.gpg.devel
Message-ID	<[email protected]>

Hi Werner,

Werner Koch <[email protected]> writes:

> On Tue, 29 Apr 2025 21:01, Collin Funk said:
>> (has_only_base64): Use memchr since calling strchr on a non-NUL
>> terminated string is undefined behavior.
>
> Very good catch.  I was my fault 22 years ago:
> [...]
> Thanks for the patch.  I am going to apply this to all branches.

Thanks! It was the first time I was alerted to a bug by this new GCC 15
warning. The other cases I saw in Gnulib and Emacs were harmless.

> Regarding the nonstring attribute we need to wait that we can make
> libgpg-error 1.55 a requirement.  That version provides the
> GPGRT_ATTR_NONSTRING.  For master we might soon make this a dependency
> but not for the other branches.

Sure, I saw that macro was recently added which was why my patch used
internal macros. But if you prefer to not duplicate the GCC version
checks and such that is fine by me.

Collin

_______________________________________________
Gnupg-devel mailing list
[email protected]
https://lists.gnupg.org/mailman/listinfo/gnupg-devel

signature.asc (application/pgp-signature, 832 B)