Re: [PATCH Libgpg-error] argparse: Remove a duplicated condition.

Werner Koch via Gnupg-devel <[email protected]> Tue, 10 Jun 2025 10:23:03 +0200

Newsgroups	gmane.comp.encryption.gpg.devel
Message-ID	<[email protected]>

On Sat,  7 Jun 2025 19:53, Collin Funk said:

>> Would "(!arg->internal || !arg->internal->confname)" be a better
>> replacement?
>
> Good questions. I did not consider that maybe that was the original
> intention when writing this...

I can't remember but I guess the idea was more my usual pattern of

      if (!arg->internal->confname || !*arg->internal->confname)
        return NULL;  /* No system conf file known.  */

and the code havin a typo.  However, at other places the code does also
not check for an empy (zero length) file name.  Thus your original patch
is okay.


Salam-Shalom,

   Werner

-- 
The pioneers of a warless world are the youth that
refuse military service.             - A. Einstein

_______________________________________________
Gnupg-devel mailing list
[email protected]
https://lists.gnupg.org/mailman/listinfo/gnupg-devel

openpgp-digital-signature.asc (application/pgp-signature, 247 B)