Re: [PATCH libgpg-error] Add support for IBM z/OS

Sachin T via Gnupg-devel wrote:
> Please review patch required for IBM z/OS platform.

I'm grossly unqualified to review the main goal of the
patch, but there are a few things which jumped out about the
formatting.

[...]
>>From cbea5636c31668ae238d899dfa6d1f4682704f83 Mon Sep 17 00:00:00 2001
> From: Sachin T [email protected]<mailto:[email protected]>
> Date: Tue, 10 Jun 2025 20:14:04 +0530
> Subject: [PATCH] Add patches for IBM z/OS
> 
> Signed-off-by: Sachin T [email protected]<mailto:[email protected]>

This seems to have been copy/pasted and the mailer and/or
other app(s) handling the patch files have added an unwanted
mailto: link.

> ---
> src/Makefile.am   |  2 +-
> src/spawn-posix.c | 13 +++++++++++++
> 2 files changed, 14 insertions(+), 1 deletion(-)
> 
> diff --git a/src/Makefile.am b/src/Makefile.am
> index e56bb23..7e874cf 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -275,7 +275,7 @@ errnos-sym.h: Makefile mkstrtable.awk errnos.in
> 
> mkheader$(EXEEXT_FOR_BUILD): mkheader.c Makefile
>                $(CC_FOR_BUILD) $(CFLAGS_FOR_BUILD) $(LDFLAGS_FOR_BUILD) \
> -              $(CPPFLAGS_FOR_BUILD) -g -I. -I$(srcdir) -o $@ $(srcdir)/mkheader.c
> +             $(CPPFLAGS_FOR_BUILD) -g -I. -I$(srcdir) -o $@ $(srcdir)/mkheader.c $(LIBS)

This hunk appears to be whitespace damaged.  The pre and
post lines should both use tab rather than spaces for
indenting (the different amount of spacing was the first
sign of trouble).

-- 
Todd

_______________________________________________
Gnupg-devel mailing list
[email protected]
https://lists.gnupg.org/mailman/listinfo/gnupg-devel

-----BEGIN PGP SIGNATURE-----

iHUEARYIAB0WIQSvlwC4tRNlCF6x+moHOcdGE+n45gUCaEhgkgAKCRAHOcdGE+n4
5qNjAQCLNGLh/UXtgreJRPpB66LA3vyGrf6vzpkL8Tofw6HP1gD8DGhmR5bMVaLX
VOUnZ8R+T6OfBHDheVg2ZKyi5ERR6w8=
=PeKo
-----END PGP SIGNATURE-----