Re: [PATCH gpgme] Fix an uninitialized variable.

Collin Funk via Gnupg-devel <[email protected]> Thu, 03 Jul 2025 20:42:43 -0700

Newsgroups	gmane.comp.encryption.gpg.devel
Message-ID	<[email protected]>

Collin Funk <[email protected]> writes:

> * src/engine-gpg.c (gpg_getdirect): Initialize ERR to zero to satisfy
> the loop condition.
>
> --
>
> Fixes-commit: 0a64c7d0c6d0463cf2e06b3a01ef5be4d879bcf0
> Signed-off-by: Collin Funk <[email protected]>
> ---
>  src/engine-gpg.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/engine-gpg.c b/src/engine-gpg.c
> index b3399027..c6c5c4e6 100644
> --- a/src/engine-gpg.c
> +++ b/src/engine-gpg.c
> @@ -4226,7 +4226,7 @@ gpg_getdirect (void *engine, const char *argv[],
>                 gpgme_data_t dataout, unsigned int flags)
>  {
>    engine_gpg_t gpg = engine;
> -  gpgme_error_t err;
> +  gpgme_error_t err = 0;
>    int i;
>  
>    if (!engine || !argv || !dataout || flags)

Hi Werner, forgot to CC. Looks like this was from that commit a few
months ago. The original code:

    gpgme_error_t err;
    int i;
  
    if (!engine || !argv || !dataout || flags)
      return gpg_error (GPG_ERR_INV_VALUE);
  
    for (i=0; !err && argv[i]; i++)
      if ((err = add_arg (gpg, argv[i])))
        return err;

Basically, the first iteration will always read an uninitialized
variable. Seems mostly harmless and will probably mostly work, but UB is
UB. :)

Collin

_______________________________________________
Gnupg-devel mailing list
[email protected]
https://lists.gnupg.org/mailman/listinfo/gnupg-devel

signature.asc (application/pgp-signature, 832 B)