Re: GnuTLS | mem: define symbol aliases for memory allocation functions (!2033)
Read-only notification of GnuTLS library development activities <[email protected]>
| Newsgroups | gmane.comp.encryption.gpg.gnutls.devel |
|---|---|
| Message-ID | <[email protected]> |
Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/2033 was reviewed by Alexander Sosedkin -- Alexander Sosedkin started a new discussion on lib/libgnutls.map: https://gitlab.com/gnutls/gnutls/-/merge_requests/2033#note_2872594342 > gnutls_audit_pop_context; > gnutls_audit_current_context; > + gnutls_secure_malloc; why is it in the `GNUTLS_3_8_6` -- `GNUTLS_3_8_11` section? shouldn't it get split up into more of them? -- Alexander Sosedkin started a new discussion on devel/symbols.last: https://gitlab.com/gnutls/gnutls/-/merge_requests/2033#note_2872594366 > gnutls_bye@GNUTLS_3_4 > -gnutls_calloc@GNUTLS_3_4 > +gnutls_calloc@(GNUTLS_3_4) do I understand correctly that the parentheses are an artifact of `objdump -T` output, signifying it's not a default version of the symbol? do we want it reflected in this file or do we want them stripped maybe? -- Alexander Sosedkin started a new discussion on lib/mem.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/2033#note_2872594389 > - * gnutls_global_set_mem_functions(). > + * This function should be used to deallocate memory if the library > + * allocate it. s/allocate/allocates/ -- Alexander Sosedkin started a new discussion on devel/libgnutls.abignore: https://gitlab.com/gnutls/gnutls/-/merge_requests/2033#note_2872594412 > [suppress_function] > name = gnutls_psk_allocate_server_credentials2 > + the order of commits seems backwards to me, is it only merge commits that are supposed to be testable? -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2033 You're receiving this email because of your account on gitlab.com. _______________________________________________ Gnutls-devel mailing list [email protected] http://lists.gnupg.org/mailman/listinfo/gnutls-devel