Re: GnuTLS | accelerated: accept NULL as digest argument for gnutls_hash_output (!2048)
Read-only notification of GnuTLS library development activities <[email protected]>
| Newsgroups | gmane.comp.encryption.gpg.gnutls.devel |
|---|---|
| Message-ID | <[email protected]> |
Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/2048 was reviewed by Alexander Sosedkin
--
Alexander Sosedkin started a new discussion on lib/accelerated/afalg.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/2048#note_2932667797
> struct kcapi_handle *handle = ctx;
>
> + if (digest == NULL) {
... `gnutls_hmac_output` also promises to reset the state, and I don't see that happening. A `digest=NULL` call would get silently swallowed in `_gnutls_mac_output`, and I'm not even sure how does one reach this function with `digest=NULL`.
* Why do we need this?
* Should it actually do something on the kcapi level instead?
* Do we need a similar round of fixes for lib/accelerated/*/hmac*?
--
Alexander Sosedkin started a new discussion on lib/crypto-selftests.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/2048#note_2932667818
> + }
> +
> + /* First feed a dummy content */
nit: "content" is uncountable
--
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2048
You're receiving this email because of your account on gitlab.com.
_______________________________________________
Gnutls-devel mailing list
[email protected]
http://lists.gnupg.org/mailman/listinfo/gnutls-devel