GnuTLS | pkcs11: properly fall back to thread-unsafe module init (!2049)
Read-only notification of GnuTLS library development activities <[email protected]>
| Newsgroups | gmane.comp.encryption.gpg.gnutls.devel |
|---|---|
| Message-ID | <[email protected]> |
Daiki Ueno created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/2049 Project:Branches: dueno/gnutls:wip/dueno/pkcs11-thread-fixes to gnutls/gnutls:master Author: Daiki Ueno <!-- Add a description of the new feature/bug fix. Reference any relevant bugs. --> * pkcs11: properly fall back to thread-unsafe module init The PKCS#11 module initialization logic introduced in aa5f15a872e62e54abe58624ee393e68d1faf689 first attempts to initialize the module with the CKR_NEED_TO_CREATE_THREADS|CKF_OS_LOCKING_OK may return either CKR_CANT_LOCK or CKR_NEED_TO_CREATE_THREADS, where the latter was previously treated as a hard error. This fixes it and also makes the second attempt to not supply any flags. Fixes: #1774 ## Checklist * [x] Commits have `Signed-off-by:` with name/author being identical to the commit author * [ ] Code modified for feature * [ ] Test suite updated with functionality tests * [ ] Test suite updated with negative tests * [ ] Documentation updated / NEWS entry present (for non-trivial changes) ## Reviewer's checklist: * [ ] Any issues marked for closing are addressed * [ ] There is a test suite reasonably covering new functionality or modifications * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md` * [ ] This feature/change has adequate documentation added * [ ] No obvious mistakes in the code -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2049 You're receiving this email because of your account on gitlab.com. _______________________________________________ Gnutls-devel mailing list [email protected] http://lists.gnupg.org/mailman/listinfo/gnutls-devel