Re: GnuTLS | rnd: always clear internal RNG state and confidential temporary data (!2051)

Read-only notification of GnuTLS library development activities <[email protected]> Wed, 14 Jan 2026 05:43:48 +0000

Newsgroups	gmane.comp.encryption.gpg.gnutls.devel
Message-ID	<[email protected]>


Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/2051 was reviewed by Daiki Ueno

--
  
Daiki Ueno started a new discussion on lib/nettle/rnd.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/2051#note_3004253700

 > +	zeroize_key(new_key, sizeof(new_key));
 >  	gnutls_free(ctx);
 >  	return ret;

Not a fault of this MR, but I would write like this to share the common code:

```suggestion:-8+0
	*_ctx = _gnutls_steal_pointer(ctx);

cleanup:
	zeroize_key(new_key, sizeof(new_key));
	gnutls_free(ctx);
	return ret;
```

You would need to change `goto fail` to `goto cleanup`, and initialize `ret` to 0.


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2051
You're receiving this email because of your account on gitlab.com.

_______________________________________________
Gnutls-devel mailing list
[email protected]
http://lists.gnupg.org/mailman/listinfo/gnutls-devel