GnuTLS | tests/scripts/common.sh: avoid IPv6 in check_if_port_* (!2057)
Read-only notification of GnuTLS library development activities <[email protected]>
| Newsgroups | gmane.comp.encryption.gpg.gnutls.devel |
|---|---|
| Message-ID | <[email protected]> |
Alexander Sosedkin created a merge request: https://gitlab.com/gnutls/gnutls/-/merge_requests/2057 Project:Branches: asosedkin/gnutls:getport-avoid-ipv6 to gnutls/gnutls:master Author: Alexander Sosedkin <!-- Add a description of the new feature/bug fix. Reference any relevant bugs. --> * tests/scripts/common.sh: avoid IPv6 in check_if_port_* I've encountered a race condition when IPv4 couldn't bind, IPv6 did bind, the check passed because IPv6 could bind, but then tlsfuzzer testsuite used IPv4 and failed. One of the simplest solutions is to filter out IPv6 in the checks. Signed-off-by: Alexander Sosedkin <[email protected]> I know it's not exactly the cleanest approach, and I'm open to better ideas. ## Checklist * [x] Commits have `Signed-off-by:` with name/author being identical to the commit author * [ ] Code modified for feature * [ ] Test suite updated with functionality tests * [ ] Test suite updated with negative tests * [ ] Documentation updated / NEWS entry present (for non-trivial changes) ## Reviewer's checklist: * [ ] Any issues marked for closing are addressed * [ ] There is a test suite reasonably covering new functionality or modifications * [ ] Function naming, parameters, return values, types, etc., are consistent and according to `CONTRIBUTION.md` * [ ] This feature/change has adequate documentation added * [ ] No obvious mistakes in the code -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2057 You're receiving this email because of your account on gitlab.com. _______________________________________________ Gnutls-devel mailing list [email protected] http://lists.gnupg.org/mailman/listinfo/gnutls-devel