Re: GnuTLS | Fix parsing of BIT STRING encoded EdDSA keys (!2060)

Read-only notification of GnuTLS library development activities <[email protected]>
Newsgroups gmane.comp.encryption.gpg.gnutls.devel
Message-ID <[email protected]>


Zoltán Fridrich commented on a discussion on lib/pubkey.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/2060#note_3046637989

 > +						       &len_len);
 > +			if (data_len < 0)
 > +				return gnutls_assert_val(
 > +					GNUTLS_E_ASN1_DER_ERROR);
 > +
 > +			/* skip first byte of data (number of unused bits at the end) */
 > +			raw_point.data = ecpoint->data + tag_len + len_len + 1;
 > +			raw_point.size = data_len - 1;
 >  			break;
 > -		case 0x04:
 > -			etype = ASN1_ETYPE_OCTET_STRING;
 > +		case 0x04: /* OCTET STRING */
 > +			ret = asn1_decode_simple_der(
 > +				ASN1_ETYPE_OCTET_STRING, ecpoint->data,
 > +				ecpoint->size,
 > +				(const unsigned char **)&raw_point.data,

No, it is not.
>From libtasn1 manual: asn1_decode_simple_der
"Decodes a simple DER encoded type (e.g. a string, which is not constructed). The output is a pointer inside the der ."

-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2060#note_3046637989
You're receiving this email because of your account on gitlab.com.

_______________________________________________
Gnutls-devel mailing list
[email protected]
http://lists.gnupg.org/mailman/listinfo/gnutls-devel
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.