Re: GnuTLS | Fix parsing of BIT STRING encoded EdDSA keys (!2060)

Read-only notification of GnuTLS library development activities <[email protected]>
Newsgroups gmane.comp.encryption.gpg.gnutls.devel
Message-ID <[email protected]>

Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/2060 was reviewed by Alexander Sosedkin

--
  
Alexander Sosedkin started a new discussion on lib/pubkey.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/2060#note_3097844467

 > +					GNUTLS_E_ASN1_DER_ERROR);
 > +
 > +			/* skip first byte of data (number of unused bits at the end) */

should there be a check for its value to be zero?

--
  
Alexander Sosedkin started a new discussion on tests/pkcs11/eddsa-ecpoint-encodings.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/2060#note_3097844492

 > +				    const gnutls_datum_t *ecpoint);
 > +
 > +static const unsigned char ecpoint_raw_data[] = {

nit: maybe macro out the repeating part so that it's easier to see how these differ?


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2060
You're receiving this email because of your account on gitlab.com. Unsubscribe from this thread: https://gitlab.com/-/sent_notifications/3-6xlhb7ev7mmn194cxt33islqs/unsubscribe | Manage all notifications: https://gitlab.com/-/profile/notifications | Help: https://gitlab.com/help

_______________________________________________
Gnutls-devel mailing list
[email protected]
http://lists.gnupg.org/mailman/listinfo/gnutls-devel
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.