Re: GnuTLS | Draft: [RFC]Add new API to fetch privkey type (!2074)
Read-only notification of GnuTLS library development activities <[email protected]>
| Newsgroups | gmane.comp.encryption.gpg.gnutls.devel |
|---|---|
| Message-ID | <[email protected]> |
Daiki Ueno commented on a discussion: https://gitlab.com/gnutls/gnutls/-/merge_requests/2074#note_3126922938
After looking at the code more closely, it feels to me that `gnutls_pkcs11_privkey_t` is not the right place to add this kind of API, as it's backed by PKCS#11 URI; so I like your initial approach more.
Only one suggestion is that, currently the function looks like:
```c
int gnutls_pkcs11_get_privkey_type(gnutls_pkcs11_obj_t obj,
gnutls_pk_algorithm_t *pk,
gnutls_ecc_curve_t *curve,
unsigned int *bits);
```
which could be:
```c
gnutls_pk_algorithm_t gnutls_pkcs11_obj_get_pk_algorithm(gnutls_pkcs11_obj_t obj,
unsigned int *bits);
```
so that the API is in line with other _get_pk_algorithm functions.
--
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2074#note_3126922938
You're receiving this email because of your account on gitlab.com. Unsubscribe from this thread: https://gitlab.com/-/sent_notifications/3-0rk0p9vfwyg781kfj3ep5myw1/unsubscribe | Manage all notifications: https://gitlab.com/-/profile/notifications | Help: https://gitlab.com/help
_______________________________________________
Gnutls-devel mailing list
[email protected]
http://lists.gnupg.org/mailman/listinfo/gnutls-devel