Re: GnuTLS | Fix TLS 1.3 handshake (!2095)

Read-only notification of GnuTLS library development activities <[email protected]> Fri, 17 Apr 2026 01:36:31 +0000

Newsgroups	gmane.comp.encryption.gpg.gnutls.devel
Message-ID	<[email protected]>


Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/2095 was reviewed by Daiki Ueno

--
  
Daiki Ueno started a new discussion on lib/tls13/certificate_request.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/2095#note_3259476712

 >  				continue;
 >  
 > +			gnutls_pk_algorithm_t algo = se->cert_pk || se->pk;

I don't think this is correct; `algo` always end up with either `GNUTLS_PK_RSA` (= 1) or `GNUTLS_PK_UNKNOWN` (= 0). See https://www.open-std.org/jtc1/sc22/WG14/www/docs/n1256.pdf#page=101 for the explanation.

Something like `se->cert_pk != GNUTLS_PK_UNKNOWN ? se->cert_pk : se->pk` should work.


-- 
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2095
You're receiving this email because of your account on gitlab.com. Unsubscribe from this thread: https://gitlab.com/-/sent_notifications/4-csb49qwaqd5aj9jw3rg7ehjp7-a84t7/unsubscribe | Manage all notifications: https://gitlab.com/-/profile/notifications | Help: https://gitlab.com/help

_______________________________________________
Gnutls-devel mailing list
[email protected]
http://lists.gnupg.org/mailman/listinfo/gnutls-devel