Re: GnuTLS | tests/system-override-special-allowlist.sh: stop comparing debug output (!2112)
Read-only notification of GnuTLS library development activities <[email protected]> Mon, 29 Jun 2026 16:52:45 +0000
| Newsgroups | gmane.comp.encryption.gpg.gnutls.devel |
|---|---|
| Message-ID | <[email protected]> |
--===============4546271505376490614==
Content-Type: multipart/alternative;
boundary="--==_mimepart_6a42a2dd11de9_376101d5478613c";
charset=UTF-8
Content-Transfer-Encoding: 7bit
----==_mimepart_6a42a2dd11de9_376101d5478613c
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Alexander Sosedkin commented on a discussion on tests/system-override-special-allowlist.sh: https://gitlab.com/gnutls/gnutls/-/merge_requests/2112#note_3504758745
> echo 'no TLS_AES_128_GCM_SHA256 with just @SYSTEM'
> exit 1
> fi
> -if ! ${GREP} -q TLS_RSA_AES_128_GCM_SHA256 "${TMPOUTFILE}"; then
> +if ! ${GREP} -Fq TLS_RSA_AES_128_GCM_SHA256 "${TMPOUTFILE}"; then
used FGREP and tried to avoid -q as well, please re-review
--
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2112#note_3504758745
You're receiving this email because of your account on gitlab.com. Unsubscribe from this thread: https://gitlab.com/-/namespace/17175643/sent_notifications/5-baxfb0n85wdjv1gmynzymeda6-a84t7/unsubscribe | Manage all notifications: https://gitlab.com/-/profile/notifications | Help: https://gitlab.com/help
----==_mimepart_6a42a2dd11de9_376101d5478613c
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: quoted-printable
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www=
.w3.org/TR/REC-html40/loose.dtd">
<html lang=3D"en" style=3D'--code-editor-font: var(--default-mono-font, "=
GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, =
Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospac=
e;'>
<head>
<meta content=3D"text/html; charset=3Dutf-8" http-equiv=3D"Content-Type">=
<title>
GitLab
</title>
<style data-premailer=3D"ignore" type=3D"text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: hsla(0,0%,100%,.01) 0 0 1px;
}
body {
font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Ro=
boto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Colo=
r Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size=
: inherit;
}
</style>
</head>
<body style=3D'font-size: inherit; -webkit-text-shadow: hsla(0,0%,100%,.0=
1) 0 0 1px; font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"=
Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif=
,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji=
";'>
<div class=3D"content">
<p style=3D"color: #777777;">
<a href=3D"https://gitlab.com/asosedkin">Alexander Sosedkin</a>
commented on a
discussion on <a href=3D"https://gitlab.com/gnutls/gnutls/-/merge_request=
s/2112#note_3504758745">tests/system-override-special-allowlist.sh</a>:
</p>
<table class=3D"code gl-mb-5" style=3D"border-spacing: 0; margin-bottom: =
1rem; border-collapse: collapse; width: auto; font-family: monospace; fon=
t-size: 90%;" bgcolor=3D"#ffffff" width=3D"100%" cellpadding=3D"0" cellsp=
acing=3D"0">
<tr class=3D"line_holder" style=3D"line-height: 1.6;">
<td class=3D"old_line diff-line-num" data-linenumber=3D"87" style=3D"widt=
h: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-co=
lor: #ececef; border-right-style: solid; padding: inherit;" align=3D"righ=
t" bgcolor=3D"#fbfafd">
87
</td>
<td class=3D"new_line diff-line-num" data-linenumber=3D"87" style=3D"widt=
h: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-co=
lor: #ececef; border-right-style: solid; padding: inherit;" align=3D"righ=
t" bgcolor=3D"#fbfafd">
87
</td>
<td class=3D"line_content" style=3D"padding: inherit;"><pre style=3D'disp=
lay: block; font-size: 14px; color: #3a383f; position: relative; font-fam=
ily: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liber=
ation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lu=
cida console", monospace; font-variant-ligatures: none; word-break: break=
-all; word-wrap: break-word; background-color: inherit; border-radius: 2p=
x; margin: 0; padding: 0; border: inherit solid #dcdcde;'> <span class=3D=
"line" data-lang=3D"shell"> <span class=3D"nb" style=3D"color: #0086b3;">=
echo</span> <span class=3D"s1" style=3D"color: #dd1144;">'no TLS_AES_128_=
GCM_SHA256 with just @SYSTEM'</span></span>
</pre></td>
</tr>
<tr class=3D"line_holder" style=3D"line-height: 1.6;">
<td class=3D"old_line diff-line-num" data-linenumber=3D"88" style=3D"widt=
h: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-co=
lor: #ececef; border-right-style: solid; padding: inherit;" align=3D"righ=
t" bgcolor=3D"#fbfafd">
88
</td>
<td class=3D"new_line diff-line-num" data-linenumber=3D"88" style=3D"widt=
h: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-co=
lor: #ececef; border-right-style: solid; padding: inherit;" align=3D"righ=
t" bgcolor=3D"#fbfafd">
88
</td>
<td class=3D"line_content" style=3D"padding: inherit;"><pre style=3D'disp=
lay: block; font-size: 14px; color: #3a383f; position: relative; font-fam=
ily: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liber=
ation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lu=
cida console", monospace; font-variant-ligatures: none; word-break: break=
-all; word-wrap: break-word; background-color: inherit; border-radius: 2p=
x; margin: 0; padding: 0; border: inherit solid #dcdcde;'> <span class=3D=
"line" data-lang=3D"shell"> <span class=3D"nb" style=3D"color: #0086b3;">=
exit </span>1</span>
</pre></td>
</tr>
<tr class=3D"line_holder" style=3D"line-height: 1.6;">
<td class=3D"old_line diff-line-num" data-linenumber=3D"89" style=3D"widt=
h: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-co=
lor: #ececef; border-right-style: solid; padding: inherit;" align=3D"righ=
t" bgcolor=3D"#fbfafd">
89
</td>
<td class=3D"new_line diff-line-num" data-linenumber=3D"89" style=3D"widt=
h: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-co=
lor: #ececef; border-right-style: solid; padding: inherit;" align=3D"righ=
t" bgcolor=3D"#fbfafd">
89
</td>
<td class=3D"line_content" style=3D"padding: inherit;"><pre style=3D'disp=
lay: block; font-size: 14px; color: #3a383f; position: relative; font-fam=
ily: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liber=
ation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lu=
cida console", monospace; font-variant-ligatures: none; word-break: break=
-all; word-wrap: break-word; background-color: inherit; border-radius: 2p=
x; margin: 0; padding: 0; border: inherit solid #dcdcde;'> <span class=3D=
"line" data-lang=3D"shell"><span class=3D"k" style=3D"font-weight: 600;">=
fi</span></span>
</pre></td>
</tr>
<tr class=3D"line_holder old" style=3D"line-height: 1.6;">
<td class=3D"old_line diff-line-num old" data-linenumber=3D"90" style=3D"=
width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-righ=
t-color: #fac5cd; border-right-style: solid; padding: inherit;" align=3D"=
right" bgcolor=3D"#f9d7dc">
90
</td>
<td class=3D"new_line diff-line-num old" data-linenumber=3D"90" style=3D"=
width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-righ=
t-color: #fac5cd; border-right-style: solid; padding: inherit;" align=3D"=
right" bgcolor=3D"#f9d7dc">
=
</td>
<td class=3D"line_content old" style=3D"padding: inherit;" bgcolor=3D"#fb=
e9eb"><pre style=3D'display: block; font-size: 14px; color: #3a383f; posi=
tion: relative; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "D=
ejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier =
New", "andale mono", "lucida console", monospace; font-variant-ligatures:=
none; word-break: break-all; word-wrap: break-word; background-color: in=
herit; border-radius: 2px; margin: 0; padding: 0; border: inherit solid #=
dcdcde;'>-<span class=3D"line" data-lang=3D"shell"><span class=3D"k" styl=
e=3D"font-weight: 600;">if</span> <span class=3D"o" style=3D"font-weight:=
600;">!</span> <span class=3D"k" style=3D"font-weight: 600;">${</span><s=
pan class=3D"nv" style=3D"color: #008080;">GREP</span><span class=3D"k" s=
tyle=3D"font-weight: 600;">}</span> <span class=3D"nt" style=3D"color: #0=
00080;">-q</span> TLS_RSA_AES_128_GCM_SHA256 <span class=3D"s2" style=3D"=
color: #dd1144;">"</span><span class=3D"k" style=3D"font-weight: 600;">${=
</span><span class=3D"nv" style=3D"color: #008080;">TMPOUTFILE</span><spa=
n class=3D"k" style=3D"font-weight: 600;">}</span><span class=3D"s2" styl=
e=3D"color: #dd1144;">"</span><span class=3D"p">;</span> <span class=3D"k=
" style=3D"font-weight: 600;">then</span></span>
</pre></td>
</tr>
<tr class=3D"line_holder new" style=3D"line-height: 1.6;">
<td class=3D"old_line diff-line-num new" data-linenumber=3D"91" style=3D"=
width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-righ=
t-color: #c7f0d2; border-right-style: solid; padding: inherit;" align=3D"=
right" bgcolor=3D"#ddfbe6">
=
</td>
<td class=3D"new_line diff-line-num new" data-linenumber=3D"90" style=3D"=
width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-righ=
t-color: #c7f0d2; border-right-style: solid; padding: inherit;" align=3D"=
right" bgcolor=3D"#ddfbe6">
90
</td>
<td class=3D"line_content new" style=3D"padding: inherit;" bgcolor=3D"#ec=
fdf0"><pre style=3D'display: block; font-size: 14px; color: #3a383f; posi=
tion: relative; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "D=
ejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier =
New", "andale mono", "lucida console", monospace; font-variant-ligatures:=
none; word-break: break-all; word-wrap: break-word; background-color: in=
herit; border-radius: 2px; margin: 0; padding: 0; border: inherit solid #=
dcdcde;'>+<span class=3D"line" data-lang=3D"shell"><span class=3D"k" styl=
e=3D"font-weight: 600;">if</span> <span class=3D"o" style=3D"font-weight:=
600;">!</span> <span class=3D"k" style=3D"font-weight: 600;">${</span><s=
pan class=3D"nv" style=3D"color: #008080;">GREP</span><span class=3D"k" s=
tyle=3D"font-weight: 600;">}</span> <span class=3D"nt" style=3D"color: #0=
00080;">-<span class=3D"idiff left right addition" style=3D"background-co=
lor: #c7f0d2;">F</span>q</span> TLS_RSA_AES_128_GCM_SHA256 <span class=3D=
"s2" style=3D"color: #dd1144;">"</span><span class=3D"k" style=3D"font-we=
ight: 600;">${</span><span class=3D"nv" style=3D"color: #008080;">TMPOUTF=
ILE</span><span class=3D"k" style=3D"font-weight: 600;">}</span><span cla=
ss=3D"s2" style=3D"color: #dd1144;">"</span><span class=3D"p">;</span> <s=
pan class=3D"k" style=3D"font-weight: 600;">then</span></span>
</pre></td>
</tr>
</table>
<div class=3D"md" style=3D"position: relative; z-index: 1; color: #3a383f=
; word-wrap: break-word;">
<p dir=3D"auto" style=3D"color: #3a383f; margin: 0px;" align=3D"initial">=
used FGREP and tried to avoid -q as well, please re-review</p>
</div>
</div>
<div class=3D"footer" style=3D"margin-top: 10px;">
<p style=3D"font-size: small; color: #626168;">
=E2=80=94
<br>
Reply to this email directly or <a href=3D"https://gitlab.com/gnutls/gnut=
ls/-/merge_requests/2112#note_3504758745">view it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target=3D"_blan=
k" rel=3D"noopener noreferrer" href=3D"https://gitlab.com">gitlab.com</a>=
. <a href=3D"https://gitlab.com/-/namespace/17175643/sent_notifications/5=
-baxfb0n85wdjv1gmynzymeda6-a84t7/unsubscribe" target=3D"_blank" rel=3D"no=
opener noreferrer">Unsubscribe</a> from this thread =C2=B7 <a href=3D"htt=
ps://gitlab.com/-/profile/notifications" target=3D"_blank" rel=3D"noopene=
r noreferrer" class=3D"mng-notif-link">Manage all notifications</a> =C2=B7=
<a href=3D"https://gitlab.com/help" target=3D"_blank" rel=3D"noopener no=
referrer" class=3D"help-link">Help</a>
<span style=3D"color: transparent; font-size: 0; display: none; overflow:=
hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0;">
Notification message regarding https://gitlab.com/gnutls/gnutls/-/merge_r=
equests/2112#note_3504758745 at 1782751965
</span>
<script type=3D"application/ld+json">{"@context":"http://schema.org","@ty=
pe":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge requ=
est","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/2112#note_3=
504758745"}}</script>
</p>
</div>
</body>
</html>
----==_mimepart_6a42a2dd11de9_376101d5478613c--
--===============4546271505376490614==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
Gnutls-devel mailing list
[email protected]
http://lists.gnupg.org/mailman/listinfo/gnutls-devel
--===============4546271505376490614==--