Re: GnuTLS | accelerated: stop calling aarch64-linux-gnu-gcc -E on generated code (!2117)
Read-only notification of GnuTLS library development activities <[email protected]> Tue, 07 Jul 2026 21:39:18 +0000
| Newsgroups | gmane.comp.encryption.gpg.gnutls.devel |
|---|---|
| Message-ID | <[email protected]> |
--===============6399985950230680024== Content-Type: multipart/alternative; boundary="--==_mimepart_6a4d720687712_3719b3ec2505d4"; charset=UTF-8 Content-Transfer-Encoding: 7bit ----==_mimepart_6a4d720687712_3719b3ec2505d4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/2117 was reviewed by William Roberts -- William Roberts started a new discussion: https://gitlab.com/gnutls/gnutls/-/merge_requests/2117#note_3534257897 LGTM, we could also drop the setting of CC to a cross compiler for aarch64 in another patch, you don't need them. The compiler should be the same one used to compile the whole thing, so if you're cross compiling, whatever CC is set to, or just `gcc` if your compiling for the host with defaults. ``` Reviewed-by: Bill Roberts <[email protected]> Tested-by: Bill Roberts <[email protected]> ``` -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2117 You're receiving this email because of your account on gitlab.com. Unsubscribe from this thread: https://gitlab.com/-/namespace/17175643/sent_notifications/5-9kjwd97xcbd2yk8okluiz02r2-a84t7/unsubscribe | Manage all notifications: https://gitlab.com/-/profile/notifications | Help: https://gitlab.com/help ----==_mimepart_6a4d720687712_3719b3ec2505d4 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www= .w3.org/TR/REC-html40/loose.dtd"> <html lang=3D"en" style=3D'--code-editor-font: var(--default-mono-font, "= GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, = Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospac= e;'> <head> <meta content=3D"text/html; charset=3Dutf-8" http-equiv=3D"Content-Type">= <title> GitLab </title> <style data-premailer=3D"ignore" type=3D"text/css"> a { color: #1068bf; } </style> <style>img { max-width: 100%; height: auto; } body { font-size: .875rem; } body { -webkit-text-shadow: hsla(0,0%,100%,.01) 0 0 1px; } body { font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Ro= boto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Colo= r Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size= : inherit; } </style> </head> <body style=3D'font-size: inherit; -webkit-text-shadow: hsla(0,0%,100%,.0= 1) 0 0 1px; font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"= Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif= ,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji= ";'> <div class=3D"content"> <div style=3D"color: #333333; border-bottom-width: 8px; border-bottom-col= or: #ededed; border-bottom-style: solid; font-weight: bold; line-height: = 1.4; padding: 20px 0;"> Merge request <a href=3D"https://gitlab.com/gnutls/gnutls/-/merge_request= s/2117">!2117</a> was reviewed by <a href=3D"https://gitlab.com/wcroberta= rm">William Roberts</a> </div> <p style=3D"color: #777777;"> <a href=3D"https://gitlab.com/wcrobertarm">William Roberts</a> started a new <a href=3D"https://gitlab.com/gnutls/gnutls/-/merge_requests/2117#note_35= 34257897">discussion</a>: </p> <div class=3D"md" style=3D"border-bottom-width: 4px; border-bottom-color:= #ededed; border-bottom-style: solid; padding-bottom: 1em; position: rela= tive; z-index: 1; color: #3a383f; word-wrap: break-word;"> <p dir=3D"auto" style=3D"color: #3a383f; margin: 0px 0px 1rem;" align=3D"= initial">LGTM, we could also drop the setting of CC to a cross compiler f= or aarch64 in another patch, you don't need them. The compiler should be = the same one used to compile the whole thing, so if you're cross compilin= g, whatever CC is set to, or just <code style=3D'font-size: 90%; color: #= 18171d; word-wrap: break-word; background-color: #ececef; border-radius: = .25rem; margin-top: 0px; font-weight: inherit; overflow-wrap: break-word;= white-space: break-spaces; font-family: "GitLab Mono", "JetBrains Mono",= "Menlo", "DejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono= ", "Courier New", "andale mono", "lucida console", monospace; font-varian= t-ligatures: none; word-break: keep-all; padding: 0.125rem 0.25rem;'>gcc<= /code> if your compiling for the host with defaults.</p> <div class=3D"gl-relative markdown-code-block js-markdown-code" style=3D"= margin-bottom: 0px;"> <pre class=3D"code highlight js-syntax-highlight language-plaintext" v-pr= e=3D"true" style=3D'display: block; font-size: 14px; color: #3a383f; line= -height: 1.6em; overflow-x: auto; border-radius: .25rem; position: relati= ve; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans M= ono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andal= e mono", "lucida console", monospace; font-variant-ligatures: none; word-= break: break-all; word-wrap: break-word; background-color: #fbfafd; margi= n: 0px 0 1rem; padding: 12px; border: 1px solid #dcdcde;'><code style=3D'= font-size: inherit; color: inherit; word-wrap: normal; word-break: keep-a= ll; background-color: inherit; border-radius: .25rem; white-space: pre; m= argin-top: 0px; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "D= ejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier = New", "andale mono", "lucida console", monospace; font-variant-ligatures:= none; overflow-wrap: normal; padding: unset;'><span id=3D"LC1" class=3D"= line" data-lang=3D"plaintext" style=3D"margin-top: 0px;">Reviewed-by: Bil= l Roberts <[email protected]></span> <span id=3D"LC2" class=3D"line" data-lang=3D"plaintext">Tested-by: Bill R= oberts <[email protected]></span></code></pre> <copy-code></copy-code><insert-code-snippet></insert-code-snippet> </div> </div> </div> <div class=3D"footer" style=3D"margin-top: 10px;"> <p style=3D"font-size: small; color: #626168;"> =E2=80=94 <br> Reply to this email directly or <a href=3D"https://gitlab.com/gnutls/gnut= ls/-/merge_requests/2117">view it on GitLab</a>. <br> You're receiving this email because of your account on <a target=3D"_blan= k" rel=3D"noopener noreferrer" href=3D"https://gitlab.com">gitlab.com</a>= . <a href=3D"https://gitlab.com/-/namespace/17175643/sent_notifications/5= -9kjwd97xcbd2yk8okluiz02r2-a84t7/unsubscribe" target=3D"_blank" rel=3D"no= opener noreferrer">Unsubscribe</a> from this thread =C2=B7 <a href=3D"htt= ps://gitlab.com/-/profile/notifications" target=3D"_blank" rel=3D"noopene= r noreferrer" class=3D"mng-notif-link">Manage all notifications</a> =C2=B7= <a href=3D"https://gitlab.com/help" target=3D"_blank" rel=3D"noopener no= referrer" class=3D"help-link">Help</a> <span style=3D"color: transparent; font-size: 0; display: none; overflow:= hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0;"> Notification message regarding https://gitlab.com/gnutls/gnutls/-/merge_r= equests/2117 at 1783460358 </span> <script type=3D"application/ld+json">{"@context":"http://schema.org","@ty= pe":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge requ= est","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/2117"}}</sc= ript> </p> </div> </body> </html> ----==_mimepart_6a4d720687712_3719b3ec2505d4-- --===============6399985950230680024== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Gnutls-devel mailing list [email protected] http://lists.gnupg.org/mailman/listinfo/gnutls-devel --===============6399985950230680024==--