Re: GnuTLS | supported_groups: rewrite group negotiation without nested loop (!2120)
"\(Deprecated\) Read-only notification of GnuTLS library development activities" <[email protected]> Mon, 03 Aug 2026 08:44:17 +0000
| Newsgroups | gmane.comp.encryption.gpg.gnutls.devel |
|---|---|
| Message-ID | <[email protected]> |
--===============4717446270776507587==
Content-Type: multipart/alternative;
boundary="--==_mimepart_6a7054e1c634c_378d473025884c";
charset=UTF-8
Content-Transfer-Encoding: 7bit
----==_mimepart_6a7054e1c634c_378d473025884c
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Merge request https://gitlab.com/gnutls/gnutls/-/merge_requests/2120 was reviewed by Sahana Prasad
--
Sahana Prasad started a new discussion on lib/ext/supported_groups.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/2120#note_3635615392
> - /* we figure what is the minimum DH allowed for this session, if any */
> - min_dh = get_min_dh(session);
> + if (len != data_size)
Here we are forcing a strict check for length which seem correct, as opposed to the old code where padded bytes/trailing bytes were ignored, I hope that we were not tolerating such supported_groups extension previously.
--
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2120
You're receiving this email because of your account on gitlab.com. Unsubscribe from this thread: https://gitlab.com/-/namespace/17175643/sent_notifications/6-alev8ti15gva04994hobwo786-a84t7/unsubscribe | Manage all notifications: https://gitlab.com/-/profile/notifications | Help: https://gitlab.com/help
----==_mimepart_6a7054e1c634c_378d473025884c
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: quoted-printable
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www=
.w3.org/TR/REC-html40/loose.dtd">
<html lang=3D"en" style=3D'--code-editor-font: var(--default-mono-font, "=
GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, =
Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospac=
e;'>
<head>
<meta content=3D"text/html; charset=3Dutf-8" http-equiv=3D"Content-Type">=
<title>
GitLab
</title>
<style data-premailer=3D"ignore" type=3D"text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: hsla(0,0%,100%,.01) 0 0 1px;
}
body {
font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Ro=
boto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Colo=
r Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size=
: inherit;
}
</style>
</head>
<body style=3D'font-size: inherit; -webkit-text-shadow: hsla(0,0%,100%,.0=
1) 0 0 1px; font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"=
Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif=
,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji=
";'>
<div class=3D"content">
<div style=3D"color: #333333; border-bottom-width: 8px; border-bottom-col=
or: #ededed; border-bottom-style: solid; font-weight: bold; line-height: =
1.4; padding: 20px 0;">
Merge request <a href=3D"https://gitlab.com/gnutls/gnutls/-/merge_request=
s/2120">!2120</a> was reviewed by <a href=3D"https://gitlab.com/sahprasa"=
>Sahana Prasad</a>
</div>
<p style=3D"color: #777777;">
<a href=3D"https://gitlab.com/sahprasa">Sahana Prasad</a>
started a new
discussion on <a href=3D"https://gitlab.com/gnutls/gnutls/-/merge_request=
s/2120#note_3635615392">lib/ext/supported_groups.c</a>:
</p>
<table class=3D"code gl-mb-5" style=3D"border-spacing: 0; margin-bottom: =
1rem; border-collapse: collapse; width: auto; font-family: monospace; fon=
t-size: 90%;" bgcolor=3D"#ffffff" width=3D"100%" cellpadding=3D"0" cellsp=
acing=3D"0">
<tr class=3D"line_holder old" style=3D"line-height: 1.6;">
<td class=3D"old_line diff-line-num old" data-linenumber=3D"134" style=3D=
"width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-rig=
ht-color: #fac5cd; border-right-style: solid; padding: inherit;" align=3D=
"right" bgcolor=3D"#f9d7dc">
134
</td>
<td class=3D"new_line diff-line-num old" data-linenumber=3D"133" style=3D=
"width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-rig=
ht-color: #fac5cd; border-right-style: solid; padding: inherit;" align=3D=
"right" bgcolor=3D"#f9d7dc">
=
</td>
<td class=3D"line_content old" style=3D"padding: inherit;" bgcolor=3D"#fb=
e9eb"><pre style=3D'display: block; font-size: 14px; color: #3a383f; posi=
tion: relative; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "D=
ejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier =
New", "andale mono", "lucida console", monospace; font-variant-ligatures:=
none; word-break: break-all; word-wrap: break-word; background-color: in=
herit; border-radius: 2px; margin: 0; padding: 0; border: inherit solid #=
dcdcde;'>-<span class=3D"line" data-lang=3D"c"> <span class=3D"cm" style=
=3D"color: #999988; font-style: italic;">/* we figure what is the minimum=
DH allowed for this session, if any */</span></span>
</pre></td>
</tr>
<tr class=3D"line_holder old" style=3D"line-height: 1.6;">
<td class=3D"old_line diff-line-num old" data-linenumber=3D"135" style=3D=
"width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-rig=
ht-color: #fac5cd; border-right-style: solid; padding: inherit;" align=3D=
"right" bgcolor=3D"#f9d7dc">
135
</td>
<td class=3D"new_line diff-line-num old" data-linenumber=3D"133" style=3D=
"width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-rig=
ht-color: #fac5cd; border-right-style: solid; padding: inherit;" align=3D=
"right" bgcolor=3D"#f9d7dc">
=
</td>
<td class=3D"line_content old" style=3D"padding: inherit;" bgcolor=3D"#fb=
e9eb"><pre style=3D'display: block; font-size: 14px; color: #3a383f; posi=
tion: relative; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "D=
ejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier =
New", "andale mono", "lucida console", monospace; font-variant-ligatures:=
none; word-break: break-all; word-wrap: break-word; background-color: in=
herit; border-radius: 2px; margin: 0; padding: 0; border: inherit solid #=
dcdcde;'>-<span class=3D"line" data-lang=3D"c"> <span class=3D"n" style=3D=
"color: #333333;">min_dh</span> <span class=3D"o" style=3D"font-weight: 6=
00;">=3D</span> <span class=3D"n" style=3D"color: #333333;">get_min_dh</s=
pan><span class=3D"p">(</span><span class=3D"n" style=3D"color: #333333;"=
>session</span><span class=3D"p">);</span></span>
</pre></td>
</tr>
<tr class=3D"line_holder new" style=3D"line-height: 1.6;">
<td class=3D"old_line diff-line-num new" data-linenumber=3D"136" style=3D=
"width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-rig=
ht-color: #c7f0d2; border-right-style: solid; padding: inherit;" align=3D=
"right" bgcolor=3D"#ddfbe6">
=
</td>
<td class=3D"new_line diff-line-num new" data-linenumber=3D"133" style=3D=
"width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-rig=
ht-color: #c7f0d2; border-right-style: solid; padding: inherit;" align=3D=
"right" bgcolor=3D"#ddfbe6">
133
</td>
<td class=3D"line_content new" style=3D"padding: inherit;" bgcolor=3D"#ec=
fdf0"><pre style=3D'display: block; font-size: 14px; color: #3a383f; posi=
tion: relative; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "D=
ejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier =
New", "andale mono", "lucida console", monospace; font-variant-ligatures:=
none; word-break: break-all; word-wrap: break-word; background-color: in=
herit; border-radius: 2px; margin: 0; padding: 0; border: inherit solid #=
dcdcde;'>+<span class=3D"line" data-lang=3D"c"> <span class=3D"k" style=3D=
"font-weight: 600;">if</span> <span class=3D"p">(</span><span class=3D"n"=
style=3D"color: #333333;">len</span> <span class=3D"o" style=3D"font-wei=
ght: 600;">!=3D</span> <span class=3D"n" style=3D"color: #333333;">data_s=
ize</span><span class=3D"p">)</span></span>
</pre></td>
</tr>
</table>
<div class=3D"md" style=3D"border-bottom-width: 4px; border-bottom-color:=
#ededed; border-bottom-style: solid; padding-bottom: 1em; position: rela=
tive; z-index: 1; color: #3a383f; word-wrap: break-word;">
<p dir=3D"auto" style=3D"color: #3a383f; margin: 0px;" align=3D"initial">=
Here we are forcing a strict check for length which seem correct, as oppo=
sed to the old code where padded bytes/trailing bytes were ignored, I hop=
e that we were not tolerating such supported_groups extension previously.=
</p>
</div>
</div>
<div class=3D"footer" style=3D"margin-top: 10px;">
<p style=3D"font-size: small; color: #626168;">
=E2=80=94
<br>
Reply to this email directly or <a href=3D"https://gitlab.com/gnutls/gnut=
ls/-/merge_requests/2120">view it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target=3D"_blan=
k" rel=3D"noopener noreferrer" href=3D"https://gitlab.com">gitlab.com</a>=
. <a href=3D"https://gitlab.com/-/namespace/17175643/sent_notifications/6=
-alev8ti15gva04994hobwo786-a84t7/unsubscribe" target=3D"_blank" rel=3D"no=
opener noreferrer">Unsubscribe</a> from this thread =C2=B7 <a href=3D"htt=
ps://gitlab.com/-/profile/notifications" target=3D"_blank" rel=3D"noopene=
r noreferrer" class=3D"mng-notif-link">Manage all notifications</a> =C2=B7=
<a href=3D"https://gitlab.com/help" target=3D"_blank" rel=3D"noopener no=
referrer" class=3D"help-link">Help</a>
<span style=3D"color: transparent; font-size: 0; display: none; overflow:=
hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0;">
Notification message regarding https://gitlab.com/gnutls/gnutls/-/merge_r=
equests/2120 at 1785746657
</span>
<script type=3D"application/ld+json">{"@context":"http://schema.org","@ty=
pe":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge requ=
est","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/2120"}}</sc=
ript>
</p>
</div>
</body>
</html>
----==_mimepart_6a7054e1c634c_378d473025884c--
--===============4717446270776507587==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
Gnutls-devel mailing list
[email protected]
http://lists.gnupg.org/mailman/listinfo/gnutls-devel
--===============4717446270776507587==--