Re: GnuTLS | Refactor `_gnutls_buffer_pop_prefix*` (!2121)
"\(Deprecated\) Read-only notification of GnuTLS library development activities" <[email protected]> Mon, 03 Aug 2026 11:32:51 +0000
| Newsgroups | gmane.comp.encryption.gpg.gnutls.devel |
|---|---|
| Message-ID | <[email protected]> |
--===============1333662273378561413==
Content-Type: multipart/alternative;
boundary="--==_mimepart_6a707c638aec0_3719e8e451271";
charset=UTF-8
Content-Transfer-Encoding: 7bit
----==_mimepart_6a707c638aec0_3719e8e451271
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Daiki Ueno commented on a discussion on lib/str.c: https://gitlab.com/gnutls/gnutls/-/merge_requests/2121#note_3636348416
> return _gnutls_buffer_append_data(buf, ss, pfx_size);
> }
>
> -int _gnutls_buffer_pop_prefix8(gnutls_buffer_st *buf, uint8_t *data, int check)
> +int _gnutls_buffer_pop_prefix8(gnutls_buffer_st *buf, uint8_t *data)
> {
> - if (buf->length < 1) {
> - gnutls_assert();
> + if (_gnutls_buffer_pop_uint8(buf, data)) {
> return GNUTLS_E_PARSING_ERROR;
> }
>
> - *data = buf->data[0];
> -
> - if (check && *data > buf->length - 1) {
> + if (buf->length < 1 || *data > buf->length - 1) {
That's a very good point (and AI didn't notice that). Thanks :-)
--
Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2121#note_3636348416
You're receiving this email because of your account on gitlab.com. Unsubscribe from this thread: https://gitlab.com/-/namespace/17175643/sent_notifications/6-bpff8r5iiv0k3uwi6lp25c02q-a84t7/unsubscribe | Manage all notifications: https://gitlab.com/-/profile/notifications | Help: https://gitlab.com/help
----==_mimepart_6a707c638aec0_3719e8e451271
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: quoted-printable
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN" "http://www=
.w3.org/TR/REC-html40/loose.dtd">
<html lang=3D"en" style=3D'--code-editor-font: var(--default-mono-font, "=
GitLab Mono"), JetBrains Mono, Menlo, DejaVu Sans Mono, Liberation Mono, =
Consolas, Ubuntu Mono, Courier New, andale mono, lucida console, monospac=
e;'>
<head>
<meta content=3D"text/html; charset=3Dutf-8" http-equiv=3D"Content-Type">=
<title>
GitLab
</title>
<style data-premailer=3D"ignore" type=3D"text/css">
a { color: #1068bf; }
</style>
<style>img {
max-width: 100%; height: auto;
}
body {
font-size: .875rem;
}
body {
-webkit-text-shadow: hsla(0,0%,100%,.01) 0 0 1px;
}
body {
font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"Segoe UI",Ro=
boto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif,"Apple Colo=
r Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji"; font-size=
: inherit;
}
</style>
</head>
<body style=3D'font-size: inherit; -webkit-text-shadow: hsla(0,0%,100%,.0=
1) 0 0 1px; font-family: "GitLab Sans",-apple-system,BlinkMacSystemFont,"=
Segoe UI",Roboto,"Noto Sans",Ubuntu,Cantarell,"Helvetica Neue",sans-serif=
,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol","Noto Color Emoji=
";'>
<div class=3D"content">
<p style=3D"color: #777777;">
<a href=3D"https://gitlab.com/dueno">Daiki Ueno</a>
commented on a
discussion on <a href=3D"https://gitlab.com/gnutls/gnutls/-/merge_request=
s/2121#note_3636348416">lib/str.c</a>:
</p>
<table class=3D"code gl-mb-5" style=3D"border-spacing: 0; margin-bottom: =
1rem; border-collapse: collapse; width: auto; font-family: monospace; fon=
t-size: 90%;" bgcolor=3D"#ffffff" width=3D"100%" cellpadding=3D"0" cellsp=
acing=3D"0">
<tr class=3D"line_holder" style=3D"line-height: 1.6;">
<td class=3D"old_line diff-line-num" data-linenumber=3D"782" style=3D"wid=
th: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-c=
olor: #ececef; border-right-style: solid; padding: inherit;" align=3D"rig=
ht" bgcolor=3D"#fbfafd">
782
</td>
<td class=3D"new_line diff-line-num" data-linenumber=3D"846" style=3D"wid=
th: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-c=
olor: #ececef; border-right-style: solid; padding: inherit;" align=3D"rig=
ht" bgcolor=3D"#fbfafd">
846
</td>
<td class=3D"line_content" style=3D"padding: inherit;"><pre style=3D'disp=
lay: block; font-size: 14px; color: #3a383f; position: relative; font-fam=
ily: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liber=
ation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lu=
cida console", monospace; font-variant-ligatures: none; word-break: break=
-all; word-wrap: break-word; background-color: inherit; border-radius: 2p=
x; margin: 0; padding: 0; border: inherit solid #dcdcde;'> <span class=3D=
"line" data-lang=3D"c"> <span class=3D"k" style=3D"font-weight: 600;">ret=
urn</span> <span class=3D"n" style=3D"color: #333333;">_gnutls_buffer_app=
end_data</span><span class=3D"p">(</span><span class=3D"n" style=3D"color=
: #333333;">buf</span><span class=3D"p">,</span> <span class=3D"n" style=3D=
"color: #333333;">ss</span><span class=3D"p">,</span> <span class=3D"n" s=
tyle=3D"color: #333333;">pfx_size</span><span class=3D"p">);</span></span=
>
</pre></td>
</tr>
<tr class=3D"line_holder" style=3D"line-height: 1.6;">
<td class=3D"old_line diff-line-num" data-linenumber=3D"783" style=3D"wid=
th: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-c=
olor: #ececef; border-right-style: solid; padding: inherit;" align=3D"rig=
ht" bgcolor=3D"#fbfafd">
783
</td>
<td class=3D"new_line diff-line-num" data-linenumber=3D"847" style=3D"wid=
th: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-c=
olor: #ececef; border-right-style: solid; padding: inherit;" align=3D"rig=
ht" bgcolor=3D"#fbfafd">
847
</td>
<td class=3D"line_content" style=3D"padding: inherit;"><pre style=3D'disp=
lay: block; font-size: 14px; color: #3a383f; position: relative; font-fam=
ily: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liber=
ation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lu=
cida console", monospace; font-variant-ligatures: none; word-break: break=
-all; word-wrap: break-word; background-color: inherit; border-radius: 2p=
x; margin: 0; padding: 0; border: inherit solid #dcdcde;'> <span class=3D=
"line" data-lang=3D"c"><span class=3D"p">}</span></span>
</pre></td>
</tr>
<tr class=3D"line_holder" style=3D"line-height: 1.6;">
<td class=3D"old_line diff-line-num" data-linenumber=3D"784" style=3D"wid=
th: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-c=
olor: #ececef; border-right-style: solid; padding: inherit;" align=3D"rig=
ht" bgcolor=3D"#fbfafd">
784
</td>
<td class=3D"new_line diff-line-num" data-linenumber=3D"848" style=3D"wid=
th: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-c=
olor: #ececef; border-right-style: solid; padding: inherit;" align=3D"rig=
ht" bgcolor=3D"#fbfafd">
848
</td>
<td class=3D"line_content" style=3D"padding: inherit;"><pre style=3D'disp=
lay: block; font-size: 14px; color: #3a383f; position: relative; font-fam=
ily: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liber=
ation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lu=
cida console", monospace; font-variant-ligatures: none; word-break: break=
-all; word-wrap: break-word; background-color: inherit; border-radius: 2p=
x; margin: 0; padding: 0; border: inherit solid #dcdcde;'> <span class=3D=
"line" data-lang=3D"c"></span>
</pre></td>
</tr>
<tr class=3D"line_holder old" style=3D"line-height: 1.6;">
<td class=3D"old_line diff-line-num old" data-linenumber=3D"785" style=3D=
"width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-rig=
ht-color: #fac5cd; border-right-style: solid; padding: inherit;" align=3D=
"right" bgcolor=3D"#f9d7dc">
785
</td>
<td class=3D"new_line diff-line-num old" data-linenumber=3D"849" style=3D=
"width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-rig=
ht-color: #fac5cd; border-right-style: solid; padding: inherit;" align=3D=
"right" bgcolor=3D"#f9d7dc">
=
</td>
<td class=3D"line_content old" style=3D"padding: inherit;" bgcolor=3D"#fb=
e9eb"><pre style=3D'display: block; font-size: 14px; color: #3a383f; posi=
tion: relative; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "D=
ejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier =
New", "andale mono", "lucida console", monospace; font-variant-ligatures:=
none; word-break: break-all; word-wrap: break-word; background-color: in=
herit; border-radius: 2px; margin: 0; padding: 0; border: inherit solid #=
dcdcde;'>-<span class=3D"line" data-lang=3D"c"><span class=3D"kt" style=3D=
"color: #445588; font-weight: 600;">int</span> <span class=3D"nf" style=3D=
"color: #990000; font-weight: 600;">_gnutls_buffer_pop_prefix8</span><spa=
n class=3D"p">(</span><span class=3D"n" style=3D"color: #333333;">gnutls_=
buffer_st</span> <span class=3D"o" style=3D"font-weight: 600;">*</span><s=
pan class=3D"n" style=3D"color: #333333;">buf</span><span class=3D"p">,</=
span> <span class=3D"kt" style=3D"color: #445588; font-weight: 600;">uint=
8_t</span> <span class=3D"o" style=3D"font-weight: 600;">*</span><span cl=
ass=3D"n" style=3D"color: #333333;">data</span><span class=3D"p"><span cl=
ass=3D"idiff left deletion" style=3D"background-color: #fac5cd;">,</span>=
</span><span class=3D"idiff deletion" style=3D"background-color: #fac5cd;=
"> </span><span class=3D"kt" style=3D"color: #445588; font-weight: 600;">=
<span class=3D"idiff deletion" style=3D"background-color: #fac5cd;">int</=
span></span><span class=3D"idiff deletion" style=3D"background-color: #fa=
c5cd;"> </span><span class=3D"n" style=3D"color: #333333;"><span class=3D=
"idiff right deletion" style=3D"background-color: #fac5cd;">check</span><=
/span><span class=3D"p">)</span></span>
</pre></td>
</tr>
<tr class=3D"line_holder new" style=3D"line-height: 1.6;">
<td class=3D"old_line diff-line-num new" data-linenumber=3D"786" style=3D=
"width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-rig=
ht-color: #c7f0d2; border-right-style: solid; padding: inherit;" align=3D=
"right" bgcolor=3D"#ddfbe6">
=
</td>
<td class=3D"new_line diff-line-num new" data-linenumber=3D"849" style=3D=
"width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-rig=
ht-color: #c7f0d2; border-right-style: solid; padding: inherit;" align=3D=
"right" bgcolor=3D"#ddfbe6">
849
</td>
<td class=3D"line_content new" style=3D"padding: inherit;" bgcolor=3D"#ec=
fdf0"><pre style=3D'display: block; font-size: 14px; color: #3a383f; posi=
tion: relative; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "D=
ejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier =
New", "andale mono", "lucida console", monospace; font-variant-ligatures:=
none; word-break: break-all; word-wrap: break-word; background-color: in=
herit; border-radius: 2px; margin: 0; padding: 0; border: inherit solid #=
dcdcde;'>+<span class=3D"line" data-lang=3D"c"><span class=3D"kt" style=3D=
"color: #445588; font-weight: 600;">int</span> <span class=3D"nf" style=3D=
"color: #990000; font-weight: 600;">_gnutls_buffer_pop_prefix8</span><spa=
n class=3D"p">(</span><span class=3D"n" style=3D"color: #333333;">gnutls_=
buffer_st</span> <span class=3D"o" style=3D"font-weight: 600;">*</span><s=
pan class=3D"n" style=3D"color: #333333;">buf</span><span class=3D"p">,</=
span> <span class=3D"kt" style=3D"color: #445588; font-weight: 600;">uint=
8_t</span> <span class=3D"o" style=3D"font-weight: 600;">*</span><span cl=
ass=3D"n" style=3D"color: #333333;">data</span><span class=3D"p">)</span>=
</span>
</pre></td>
</tr>
<tr class=3D"line_holder" style=3D"line-height: 1.6;">
<td class=3D"old_line diff-line-num" data-linenumber=3D"786" style=3D"wid=
th: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-c=
olor: #ececef; border-right-style: solid; padding: inherit;" align=3D"rig=
ht" bgcolor=3D"#fbfafd">
786
</td>
<td class=3D"new_line diff-line-num" data-linenumber=3D"850" style=3D"wid=
th: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-c=
olor: #ececef; border-right-style: solid; padding: inherit;" align=3D"rig=
ht" bgcolor=3D"#fbfafd">
850
</td>
<td class=3D"line_content" style=3D"padding: inherit;"><pre style=3D'disp=
lay: block; font-size: 14px; color: #3a383f; position: relative; font-fam=
ily: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liber=
ation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lu=
cida console", monospace; font-variant-ligatures: none; word-break: break=
-all; word-wrap: break-word; background-color: inherit; border-radius: 2p=
x; margin: 0; padding: 0; border: inherit solid #dcdcde;'> <span class=3D=
"line" data-lang=3D"c"><span class=3D"p">{</span></span>
</pre></td>
</tr>
<tr class=3D"line_holder old" style=3D"line-height: 1.6;">
<td class=3D"old_line diff-line-num old" data-linenumber=3D"787" style=3D=
"width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-rig=
ht-color: #fac5cd; border-right-style: solid; padding: inherit;" align=3D=
"right" bgcolor=3D"#f9d7dc">
787
</td>
<td class=3D"new_line diff-line-num old" data-linenumber=3D"851" style=3D=
"width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-rig=
ht-color: #fac5cd; border-right-style: solid; padding: inherit;" align=3D=
"right" bgcolor=3D"#f9d7dc">
=
</td>
<td class=3D"line_content old" style=3D"padding: inherit;" bgcolor=3D"#fb=
e9eb"><pre style=3D'display: block; font-size: 14px; color: #3a383f; posi=
tion: relative; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "D=
ejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier =
New", "andale mono", "lucida console", monospace; font-variant-ligatures:=
none; word-break: break-all; word-wrap: break-word; background-color: in=
herit; border-radius: 2px; margin: 0; padding: 0; border: inherit solid #=
dcdcde;'>-<span class=3D"line" data-lang=3D"c"> <span class=3D"k" style=3D=
"font-weight: 600;">if</span> <span class=3D"p">(</span><span class=3D"n"=
style=3D"color: #333333;">buf</span><span class=3D"o" style=3D"font-weig=
ht: 600;">-></span><span class=3D"n" style=3D"color: #333333;">length<=
/span> <span class=3D"o" style=3D"font-weight: 600;"><</span> <span cl=
ass=3D"mi" style=3D"color: #009999;">1</span><span class=3D"p">)</span> <=
span class=3D"p">{</span></span>
</pre></td>
</tr>
<tr class=3D"line_holder old" style=3D"line-height: 1.6;">
<td class=3D"old_line diff-line-num old" data-linenumber=3D"788" style=3D=
"width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-rig=
ht-color: #fac5cd; border-right-style: solid; padding: inherit;" align=3D=
"right" bgcolor=3D"#f9d7dc">
788
</td>
<td class=3D"new_line diff-line-num old" data-linenumber=3D"851" style=3D=
"width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-rig=
ht-color: #fac5cd; border-right-style: solid; padding: inherit;" align=3D=
"right" bgcolor=3D"#f9d7dc">
=
</td>
<td class=3D"line_content old" style=3D"padding: inherit;" bgcolor=3D"#fb=
e9eb"><pre style=3D'display: block; font-size: 14px; color: #3a383f; posi=
tion: relative; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "D=
ejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier =
New", "andale mono", "lucida console", monospace; font-variant-ligatures:=
none; word-break: break-all; word-wrap: break-word; background-color: in=
herit; border-radius: 2px; margin: 0; padding: 0; border: inherit solid #=
dcdcde;'>-<span class=3D"line" data-lang=3D"c"> <span class=3D"n" style=3D=
"color: #333333;">gnutls_assert</span><span class=3D"p">();</span></span>=
</pre></td>
</tr>
<tr class=3D"line_holder new" style=3D"line-height: 1.6;">
<td class=3D"old_line diff-line-num new" data-linenumber=3D"789" style=3D=
"width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-rig=
ht-color: #c7f0d2; border-right-style: solid; padding: inherit;" align=3D=
"right" bgcolor=3D"#ddfbe6">
=
</td>
<td class=3D"new_line diff-line-num new" data-linenumber=3D"851" style=3D=
"width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-rig=
ht-color: #c7f0d2; border-right-style: solid; padding: inherit;" align=3D=
"right" bgcolor=3D"#ddfbe6">
851
</td>
<td class=3D"line_content new" style=3D"padding: inherit;" bgcolor=3D"#ec=
fdf0"><pre style=3D'display: block; font-size: 14px; color: #3a383f; posi=
tion: relative; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "D=
ejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier =
New", "andale mono", "lucida console", monospace; font-variant-ligatures:=
none; word-break: break-all; word-wrap: break-word; background-color: in=
herit; border-radius: 2px; margin: 0; padding: 0; border: inherit solid #=
dcdcde;'>+<span class=3D"line" data-lang=3D"c"> <span class=3D"k" style=3D=
"font-weight: 600;">if</span> <span class=3D"p">(</span><span class=3D"n"=
style=3D"color: #333333;">_gnutls_buffer_pop_uint8</span><span class=3D"=
p">(</span><span class=3D"n" style=3D"color: #333333;">buf</span><span cl=
ass=3D"p">,</span> <span class=3D"n" style=3D"color: #333333;">data</span=
><span class=3D"p">))</span> <span class=3D"p">{</span></span>
</pre></td>
</tr>
<tr class=3D"line_holder" style=3D"line-height: 1.6;">
<td class=3D"old_line diff-line-num" data-linenumber=3D"789" style=3D"wid=
th: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-c=
olor: #ececef; border-right-style: solid; padding: inherit;" align=3D"rig=
ht" bgcolor=3D"#fbfafd">
789
</td>
<td class=3D"new_line diff-line-num" data-linenumber=3D"852" style=3D"wid=
th: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-c=
olor: #ececef; border-right-style: solid; padding: inherit;" align=3D"rig=
ht" bgcolor=3D"#fbfafd">
852
</td>
<td class=3D"line_content" style=3D"padding: inherit;"><pre style=3D'disp=
lay: block; font-size: 14px; color: #3a383f; position: relative; font-fam=
ily: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liber=
ation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lu=
cida console", monospace; font-variant-ligatures: none; word-break: break=
-all; word-wrap: break-word; background-color: inherit; border-radius: 2p=
x; margin: 0; padding: 0; border: inherit solid #dcdcde;'> <span class=3D=
"line" data-lang=3D"c"> <span class=3D"k" style=3D"font-weight: 600;">re=
turn</span> <span class=3D"n" style=3D"color: #333333;">GNUTLS_E_PARSING_=
ERROR</span><span class=3D"p">;</span></span>
</pre></td>
</tr>
<tr class=3D"line_holder" style=3D"line-height: 1.6;">
<td class=3D"old_line diff-line-num" data-linenumber=3D"790" style=3D"wid=
th: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-c=
olor: #ececef; border-right-style: solid; padding: inherit;" align=3D"rig=
ht" bgcolor=3D"#fbfafd">
790
</td>
<td class=3D"new_line diff-line-num" data-linenumber=3D"853" style=3D"wid=
th: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-c=
olor: #ececef; border-right-style: solid; padding: inherit;" align=3D"rig=
ht" bgcolor=3D"#fbfafd">
853
</td>
<td class=3D"line_content" style=3D"padding: inherit;"><pre style=3D'disp=
lay: block; font-size: 14px; color: #3a383f; position: relative; font-fam=
ily: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liber=
ation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lu=
cida console", monospace; font-variant-ligatures: none; word-break: break=
-all; word-wrap: break-word; background-color: inherit; border-radius: 2p=
x; margin: 0; padding: 0; border: inherit solid #dcdcde;'> <span class=3D=
"line" data-lang=3D"c"> <span class=3D"p">}</span></span>
</pre></td>
</tr>
<tr class=3D"line_holder" style=3D"line-height: 1.6;">
<td class=3D"old_line diff-line-num" data-linenumber=3D"791" style=3D"wid=
th: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-c=
olor: #ececef; border-right-style: solid; padding: inherit;" align=3D"rig=
ht" bgcolor=3D"#fbfafd">
791
</td>
<td class=3D"new_line diff-line-num" data-linenumber=3D"854" style=3D"wid=
th: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-right-c=
olor: #ececef; border-right-style: solid; padding: inherit;" align=3D"rig=
ht" bgcolor=3D"#fbfafd">
854
</td>
<td class=3D"line_content" style=3D"padding: inherit;"><pre style=3D'disp=
lay: block; font-size: 14px; color: #3a383f; position: relative; font-fam=
ily: "GitLab Mono", "JetBrains Mono", "Menlo", "DejaVu Sans Mono", "Liber=
ation Mono", "Consolas", "Ubuntu Mono", "Courier New", "andale mono", "lu=
cida console", monospace; font-variant-ligatures: none; word-break: break=
-all; word-wrap: break-word; background-color: inherit; border-radius: 2p=
x; margin: 0; padding: 0; border: inherit solid #dcdcde;'> <span class=3D=
"line" data-lang=3D"c"></span>
</pre></td>
</tr>
<tr class=3D"line_holder old" style=3D"line-height: 1.6;">
<td class=3D"old_line diff-line-num old" data-linenumber=3D"792" style=3D=
"width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-rig=
ht-color: #fac5cd; border-right-style: solid; padding: inherit;" align=3D=
"right" bgcolor=3D"#f9d7dc">
792
</td>
<td class=3D"new_line diff-line-num old" data-linenumber=3D"855" style=3D=
"width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-rig=
ht-color: #fac5cd; border-right-style: solid; padding: inherit;" align=3D=
"right" bgcolor=3D"#f9d7dc">
=
</td>
<td class=3D"line_content old" style=3D"padding: inherit;" bgcolor=3D"#fb=
e9eb"><pre style=3D'display: block; font-size: 14px; color: #3a383f; posi=
tion: relative; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "D=
ejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier =
New", "andale mono", "lucida console", monospace; font-variant-ligatures:=
none; word-break: break-all; word-wrap: break-word; background-color: in=
herit; border-radius: 2px; margin: 0; padding: 0; border: inherit solid #=
dcdcde;'>-<span class=3D"line" data-lang=3D"c"> <span class=3D"o" style=3D=
"font-weight: 600;">*</span><span class=3D"n" style=3D"color: #333333;">d=
ata</span> <span class=3D"o" style=3D"font-weight: 600;">=3D</span> <span=
class=3D"n" style=3D"color: #333333;">buf</span><span class=3D"o" style=3D=
"font-weight: 600;">-></span><span class=3D"n" style=3D"color: #333333=
;">data</span><span class=3D"p">[</span><span class=3D"mi" style=3D"color=
: #009999;">0</span><span class=3D"p">];</span></span>
</pre></td>
</tr>
<tr class=3D"line_holder old" style=3D"line-height: 1.6;">
<td class=3D"old_line diff-line-num old" data-linenumber=3D"793" style=3D=
"width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-rig=
ht-color: #fac5cd; border-right-style: solid; padding: inherit;" align=3D=
"right" bgcolor=3D"#f9d7dc">
793
</td>
<td class=3D"new_line diff-line-num old" data-linenumber=3D"855" style=3D=
"width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-rig=
ht-color: #fac5cd; border-right-style: solid; padding: inherit;" align=3D=
"right" bgcolor=3D"#f9d7dc">
=
</td>
<td class=3D"line_content old" style=3D"padding: inherit;" bgcolor=3D"#fb=
e9eb"><pre style=3D'display: block; font-size: 14px; color: #3a383f; posi=
tion: relative; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "D=
ejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier =
New", "andale mono", "lucida console", monospace; font-variant-ligatures:=
none; word-break: break-all; word-wrap: break-word; background-color: in=
herit; border-radius: 2px; margin: 0; padding: 0; border: inherit solid #=
dcdcde;'>-<span class=3D"line" data-lang=3D"c"></span>
</pre></td>
</tr>
<tr class=3D"line_holder old" style=3D"line-height: 1.6;">
<td class=3D"old_line diff-line-num old" data-linenumber=3D"794" style=3D=
"width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-rig=
ht-color: #fac5cd; border-right-style: solid; padding: inherit;" align=3D=
"right" bgcolor=3D"#f9d7dc">
794
</td>
<td class=3D"new_line diff-line-num old" data-linenumber=3D"855" style=3D=
"width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-rig=
ht-color: #fac5cd; border-right-style: solid; padding: inherit;" align=3D=
"right" bgcolor=3D"#f9d7dc">
=
</td>
<td class=3D"line_content old" style=3D"padding: inherit;" bgcolor=3D"#fb=
e9eb"><pre style=3D'display: block; font-size: 14px; color: #3a383f; posi=
tion: relative; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "D=
ejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier =
New", "andale mono", "lucida console", monospace; font-variant-ligatures:=
none; word-break: break-all; word-wrap: break-word; background-color: in=
herit; border-radius: 2px; margin: 0; padding: 0; border: inherit solid #=
dcdcde;'>-<span class=3D"line" data-lang=3D"c"> <span class=3D"k" style=3D=
"font-weight: 600;">if</span> <span class=3D"p">(</span><span class=3D"n"=
style=3D"color: #333333;">check</span> <span class=3D"o" style=3D"font-w=
eight: 600;">&&</span> <span class=3D"o" style=3D"font-weight: 60=
0;">*</span><span class=3D"n" style=3D"color: #333333;">data</span> <span=
class=3D"o" style=3D"font-weight: 600;">></span> <span class=3D"n" st=
yle=3D"color: #333333;">buf</span><span class=3D"o" style=3D"font-weight:=
600;">-></span><span class=3D"n" style=3D"color: #333333;">length</sp=
an> <span class=3D"o" style=3D"font-weight: 600;">-</span> <span class=3D=
"mi" style=3D"color: #009999;">1</span><span class=3D"p">)</span> <span c=
lass=3D"p">{</span></span>
</pre></td>
</tr>
<tr class=3D"line_holder new" style=3D"line-height: 1.6;">
<td class=3D"old_line diff-line-num new" data-linenumber=3D"795" style=3D=
"width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-rig=
ht-color: #c7f0d2; border-right-style: solid; padding: inherit;" align=3D=
"right" bgcolor=3D"#ddfbe6">
=
</td>
<td class=3D"new_line diff-line-num new" data-linenumber=3D"855" style=3D=
"width: 35px; color: rgba(5,5,6,.24); border-right-width: 1px; border-rig=
ht-color: #c7f0d2; border-right-style: solid; padding: inherit;" align=3D=
"right" bgcolor=3D"#ddfbe6">
855
</td>
<td class=3D"line_content new" style=3D"padding: inherit;" bgcolor=3D"#ec=
fdf0"><pre style=3D'display: block; font-size: 14px; color: #3a383f; posi=
tion: relative; font-family: "GitLab Mono", "JetBrains Mono", "Menlo", "D=
ejaVu Sans Mono", "Liberation Mono", "Consolas", "Ubuntu Mono", "Courier =
New", "andale mono", "lucida console", monospace; font-variant-ligatures:=
none; word-break: break-all; word-wrap: break-word; background-color: in=
herit; border-radius: 2px; margin: 0; padding: 0; border: inherit solid #=
dcdcde;'>+<span class=3D"line" data-lang=3D"c"> <span class=3D"k" style=3D=
"font-weight: 600;">if</span> <span class=3D"p">(</span><span class=3D"n"=
style=3D"color: #333333;">buf</span><span class=3D"o" style=3D"font-weig=
ht: 600;">-></span><span class=3D"n" style=3D"color: #333333;">length<=
/span> <span class=3D"o" style=3D"font-weight: 600;"><</span> <span cl=
ass=3D"mi" style=3D"color: #009999;">1</span> <span class=3D"o" style=3D"=
font-weight: 600;">||</span> <span class=3D"o" style=3D"font-weight: 600;=
">*</span><span class=3D"n" style=3D"color: #333333;">data</span> <span c=
lass=3D"o" style=3D"font-weight: 600;">></span> <span class=3D"n" styl=
e=3D"color: #333333;">buf</span><span class=3D"o" style=3D"font-weight: 6=
00;">-></span><span class=3D"n" style=3D"color: #333333;">length</span=
> <span class=3D"o" style=3D"font-weight: 600;">-</span> <span class=3D"m=
i" style=3D"color: #009999;">1</span><span class=3D"p">)</span> <span cla=
ss=3D"p">{</span></span>
</pre></td>
</tr>
</table>
<div class=3D"md" style=3D"position: relative; z-index: 1; color: #3a383f=
; word-wrap: break-word;">
<p dir=3D"auto" style=3D"color: #3a383f; margin: 0px;" align=3D"initial">=
That's a very good point (and AI didn't notice that). Thanks :-)</p>
</div>
</div>
<div class=3D"footer" style=3D"margin-top: 10px;">
<p style=3D"font-size: small; color: #626168;">
=E2=80=94
<br>
Reply to this email directly or <a href=3D"https://gitlab.com/gnutls/gnut=
ls/-/merge_requests/2121#note_3636348416">view it on GitLab</a>.
<br>
You're receiving this email because of your account on <a target=3D"_blan=
k" rel=3D"noopener noreferrer" href=3D"https://gitlab.com">gitlab.com</a>=
. <a href=3D"https://gitlab.com/-/namespace/17175643/sent_notifications/6=
-bpff8r5iiv0k3uwi6lp25c02q-a84t7/unsubscribe" target=3D"_blank" rel=3D"no=
opener noreferrer">Unsubscribe</a> from this thread =C2=B7 <a href=3D"htt=
ps://gitlab.com/-/profile/notifications" target=3D"_blank" rel=3D"noopene=
r noreferrer" class=3D"mng-notif-link">Manage all notifications</a> =C2=B7=
<a href=3D"https://gitlab.com/help" target=3D"_blank" rel=3D"noopener no=
referrer" class=3D"help-link">Help</a>
<span style=3D"color: transparent; font-size: 0; display: none; overflow:=
hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0;">
Notification message regarding https://gitlab.com/gnutls/gnutls/-/merge_r=
equests/2121#note_3636348416 at 1785756771
</span>
<script type=3D"application/ld+json">{"@context":"http://schema.org","@ty=
pe":"EmailMessage","action":{"@type":"ViewAction","name":"View Merge requ=
est","url":"https://gitlab.com/gnutls/gnutls/-/merge_requests/2121#note_3=
636348416"}}</script>
</p>
</div>
</body>
</html>
----==_mimepart_6a707c638aec0_3719e8e451271--
--===============1333662273378561413==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
Gnutls-devel mailing list
[email protected]
http://lists.gnupg.org/mailman/listinfo/gnutls-devel
--===============1333662273378561413==--