Re: GnuTLS | Refactor `_gnutls_buffer_pop_prefix*` (!2121)
"\(Deprecated\) Read-only notification of GnuTLS library development activities" <[email protected]>
| Newsgroups | gmane.comp.encryption.gpg.gnutls.devel |
|---|---|
| Message-ID | <[email protected]> |
Alexander Sosedkin started a new discussion on lib/str.h: https://gitlab.com/gnutls/gnutls/-/merge_requests/2121#note_3648480705 > - int check); > - > -/* 24-bit prefix, if check is true, ensure there are enough bytes > - * remaining in buf */ > -int _gnutls_buffer_pop_prefix24(gnutls_buffer_st *buf, size_t *data_size, > - int check); > - > -/* 16-bit prefix, if check is true, ensure there are enough bytes > - * remaining in buf */ > -int _gnutls_buffer_pop_prefix16(gnutls_buffer_st *buf, size_t *data_size, > - int check); > - > -/* 8-bit prefix, if check is true ensure, there are enough bytes > - * remaining in buf */ > -int _gnutls_buffer_pop_prefix8(gnutls_buffer_st *buf, uint8_t *data, int check); > +/* 32-bit prefix, ensure there are no remaining bytes in buf */ the "ensure there are no remaining bytes in buf" part doesn't feel intended (and doesn't match the `*data_size > buf->length` error condition) -- Reply to this email directly or view it on GitLab: https://gitlab.com/gnutls/gnutls/-/merge_requests/2121#note_3648480705 You're receiving this email because of your account on gitlab.com. Unsubscribe from this thread: https://gitlab.com/-/namespace/17175643/sent_notifications/6-1a1461ehfqlrzbcc8ez1awa80-a84t7/unsubscribe | Manage all notifications: https://gitlab.com/-/profile/notifications | Help: https://gitlab.com/help _______________________________________________ Gnutls-devel mailing list [email protected] http://lists.gnupg.org/mailman/listinfo/gnutls-devel