Re: [PATCH] MPI helper of addition one limb, Least Leak Intended

Hello,

Jussi Kivilinna <[email protected]> wrote:
> Is LLI variant really needed? This looks the same as the 
> _gcry_mpih_add_n.

You are right.  It is not needed, actually.  I overlooked.

I'm going to fix it by:

	#define _gcry_mpih_add_lli _gcry_mpih_add_n

> I think we should remove obsolete ones in favor of just using the 
> generic
> version. I'd just keep assembly for following architectures:
>   - amd64
>   - i386
>   - aarch64
>   - arm
>   - generic
>
> We could then validate that these really have constant time (or LLI)
> implementations.

Agreed.

For the schedule, I think it should be done for 1.12.  I don't think
this kind of removal/cleanup is not needed for next revision (1.11.1).
--