Re: [PATCH 1/2] cipher: Add PUBKEY_FLAG_BYTE_STRING to support byte string data.

Werner Koch via Gcrypt-devel <[email protected]> Sun, 22 Jun 2025 19:00:48 +0200

Newsgroups	gmane.comp.encryption.gpg.libgcrypt.devel
Message-ID	<[email protected]>

On Wed, 18 Jun 2025 16:39, NIIBE Yutaka said:
> +      /* Get VALUE.  */
> +      value = sexp_nth_buffer (lvalue, 1, &valuelen);
> +      if (!value)
> +        rc = GPG_ERR_INV_OBJ;
> +      if (rc)
> +        goto leave;

Please change the above to 

> +      if (!value)
> +        {
> +          rc = GPG_ERR_INV_OBJ;
> +          goto leave;
> +        }

just because this is easier to understand and the same pattern we use
above.


Shalom-Salam,

   Werner

-- 
The pioneers of a warless world are the youth that
refuse military service.             - A. Einstein

_______________________________________________
Gcrypt-devel mailing list
[email protected]
https://lists.gnupg.org/mailman/listinfo/gcrypt-devel

openpgp-digital-signature.asc (application/pgp-signature, 247 B)