Re: [PATCH 1/2] cipher: Add PUBKEY_FLAG_BYTE_STRING to support byte string data.

NIIBE Yutaka via Gcrypt-devel <[email protected]> Tue, 24 Jun 2025 15:39:53 +0900

Newsgroups	gmane.comp.encryption.gpg.libgcrypt.devel
Message-ID	<[email protected]>

Werner Koch <[email protected]> wrote:
>> +      /* Get VALUE.  */
>> +      value = sexp_nth_buffer (lvalue, 1, &valuelen);
>> +      if (!value)
>> +        rc = GPG_ERR_INV_OBJ;
>> +      if (rc)
>> +        goto leave;
>
> Please change the above to 
>
>> +      if (!value)
>> +        {
>> +          rc = GPG_ERR_INV_OBJ;
>> +          goto leave;
>> +        }
>
> just because this is easier to understand and the same pattern we use
> above.

I see.  Following your suggestion, applied those patches and pushed to master.
--