Re: [PATCH 1/2] mceliece6688128f: fix stack overflow crash on win64/wine
Jacob Bachmeyer via Gcrypt-devel <[email protected]> Fri, 26 Sep 2025 18:19:00 -0500
| Newsgroups | gmane.comp.encryption.gpg.libgcrypt.devel |
|---|---|
| Message-ID | <[email protected]> |
On 9/26/25 01:53, Jussi Kivilinna wrote: > * cipher/mceliece6688128f.c (pk_gen): Remove 'mat' array allocation and > rename function to ... > (pk_gen_mat): ... this. > (pk_gen): New warper for 'pk_gen_mat' with dynamic allocation of 'mat' array. Typo? Did you mean "wrapper"? Why do it this way instead of just adding xmalloc()/xfree() calls to pk_gen()? Also, should the buffer be zeroed before releasing it? -- Jacob _______________________________________________ Gcrypt-devel mailing list [email protected] https://lists.gnupg.org/mailman/listinfo/gcrypt-devel