Re: [PATCH 09/10] mceliece6688128f: update generation script to apply changes as patch set

On 9/30/25 01:30, Jussi Kivilinna wrote:
> Hello,
>
> On 27/09/2025 10:54, Jussi Kivilinna wrote:
>> * cipher/mceliece6688128f-patches: New.
>> * cipher/mceliece6688128f.sh: Apply patches from
>> 'cipher/mceliece6688128f-patches/*'.
>> -- 
>
> I had to drop this commit with patch files as git server rejects this 
> with:
>
> remote: 
> cipher/mceliece6688128f-patches/0001-mceliece6688128f-fix-UBSAN-runtime-errors.patch:40: 
> trailing whitespace.
> remote: +
> remote: 
> cipher/mceliece6688128f-patches/0001-mceliece6688128f-fix-UBSAN-runtime-errors.patch:44: 
> trailing whitespace.
> remote: +
> remote: 
> cipher/mceliece6688128f-patches/0001-mceliece6688128f-fix-UBSAN-runtime-errors.patch:49: 
> trailing whitespace.
> remote: +
> <...snip...>
> remote: error: hook declined to update refs/heads/master
>
> Should I anyway try to wrestle this change in to repo? These patch 
> files could be packaged into tar.gz for example.

Could the patch be fixed to remove the trailing whitespace?  I suggest 
trying Emacs M-x whitespace-cleanup on the patches.

At a quick check, it looks like that hook may have legitimately caught 
patches that add non-empty blank lines.  Is there some reason unknown to 
me to have whitespace on seemingly blank lines in C code?


-- Jacob


_______________________________________________
Gcrypt-devel mailing list
[email protected]
https://lists.gnupg.org/mailman/listinfo/gcrypt-devel