krb5 commit: Fix Leash build error with recent Visual Studio

Greg Hudson <[email protected]>
Newsgroups gmane.comp.encryption.kerberos.cvs
Message-ID <[email protected]>
https://github.com/krb5/krb5/commit/e7315768eb52ad44e73ff1c51ef18fe5371412fc
commit e7315768eb52ad44e73ff1c51ef18fe5371412fc
Author: Greg Hudson <[email protected]>
Date:   Sun May 6 22:29:40 2018 -0400

    Fix Leash build error with recent Visual Studio
    
    Visual Studio 2015 and later do not allow manipulation of the _flag
    field inside a file handle.  In Leash's out2con.cpp (used only for the
    debugging -console flag), do not try to mark the allocated file handle
    as free after copying it to *stdout; a one-time memory leak here is
    unimportant.
    
    ticket: 8679 (new)

 src/windows/leash/out2con.cpp |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/src/windows/leash/out2con.cpp b/src/windows/leash/out2con.cpp
index f7a1d35..877eac1 100644
--- a/src/windows/leash/out2con.cpp
+++ b/src/windows/leash/out2con.cpp
@@ -96,9 +96,7 @@ ConsoleEcho::ConsoleEcho()
     FILE* fp = _fdopen(m_pipefd, "w");
     // copy to stdout
     *stdout = *fp;
-    // now slam the allocated FILE's _flag to zero to mark it as free without
-    // actually closing the os file handle and pipe
-    fp->_flag = 0;
+    // fp leaks, but we can't close it without closing the OS file handle
 
     // disable buffering
     setvbuf(stdout, NULL, _IONBF, 0);
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.