krb5 commit: Properly size #ifdef in k5_cccol_lock()

Greg Hudson <[email protected]>
Newsgroups gmane.comp.encryption.kerberos.cvs
Message-ID <[email protected]>
https://github.com/krb5/krb5/commit/444a15f9cf82b9a6c1bca3f20307f82fee91c228
commit 444a15f9cf82b9a6c1bca3f20307f82fee91c228
Author: Robbie Harwood <[email protected]>
Date:   Thu Feb 14 11:50:35 2019 -0500

    Properly size #ifdef in k5_cccol_lock()
    
    The cleanup code only could get executed in the USE_CCAPI_V3 case, so
    move it inside that block.  Reported by Coverity.

 src/lib/krb5/ccache/ccbase.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/lib/krb5/ccache/ccbase.c b/src/lib/krb5/ccache/ccbase.c
index 6715ac9..f53ba50 100644
--- a/src/lib/krb5/ccache/ccbase.c
+++ b/src/lib/krb5/ccache/ccbase.c
@@ -511,7 +511,6 @@ k5_cccol_lock(krb5_context context)
 #endif
 #ifdef USE_CCAPI_V3
     ret = krb5_stdccv3_context_lock(context);
-#endif
     if (ret) {
         k5_cc_mutex_unlock(context, &krb5int_mcc_mutex);
         k5_cc_mutex_unlock(context, &krb5int_cc_file_mutex);
@@ -519,6 +518,7 @@ k5_cccol_lock(krb5_context context)
         k5_cc_mutex_unlock(context, &cccol_lock);
         return ret;
     }
+#endif
     k5_mutex_unlock(&cc_typelist_lock);
     return ret;
 }
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.