krb5 commit: Fix KCM client time offset propagation

Greg Hudson <[email protected]>
Newsgroups gmane.comp.encryption.kerberos.cvs
Message-ID <[email protected]>
https://github.com/krb5/krb5/commit/323abb6d1ebe5469d6c2167c29aa5d696d099b90
commit 323abb6d1ebe5469d6c2167c29aa5d696d099b90
Author: Robbie Harwood <[email protected]>
Date:   Wed Aug 14 13:52:27 2019 -0400

    Fix KCM client time offset propagation
    
    An inverted status check in get_kdc_offset() would cause querying the
    offset time from the ccache to always fail (silently) on KCM.  Fix the
    status check so that KCM can properly handle desync.
    
    ticket: 8826 (new)
    tags: pullup
    target_version: 1.17-next
    target_verison: 1.16-next

 src/lib/krb5/ccache/cc_kcm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/lib/krb5/ccache/cc_kcm.c b/src/lib/krb5/ccache/cc_kcm.c
index 103cd98..1f5d6c8 100644
--- a/src/lib/krb5/ccache/cc_kcm.c
+++ b/src/lib/krb5/ccache/cc_kcm.c
@@ -577,7 +577,7 @@ get_kdc_offset(krb5_context context, krb5_ccache cache)
     if (cache_call(context, cache, &req) != 0)
         goto cleanup;
     time_offset = k5_input_get_uint32_be(&req.reply);
-    if (!req.reply.status)
+    if (req.reply.status)
         goto cleanup;
     context->os_context.time_offset = time_offset;
     context->os_context.usec_offset = 0;
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.