krb5 commit [krb5-1.18]: Suppress Leash error popup on MSLSA renew failure

Greg Hudson <[email protected]>
Newsgroups gmane.comp.encryption.kerberos.cvs
Message-ID <[email protected]>
https://github.com/krb5/krb5/commit/dde8a92e44a879c326a6f13cef590460eb7b7fac
commit dde8a92e44a879c326a6f13cef590460eb7b7fac
Author: Greg Hudson <[email protected]>
Date:   Wed Aug 19 11:49:29 2020 -0400

    Suppress Leash error popup on MSLSA renew failure
    
    Attempting to renew the MSLSA cache can commonly fail with
    KRB5_CC_NOTFOUND due to LSA policy.  Do not display an error popup in
    this case.  Also fix a logic error in the existing suppressions.
    
    (cherry picked from commit bfd407703a938573610af3f17aad4d5ebad615fd)
    
    ticket: 8939
    version_fixed: 1.18.3

 src/windows/leashdll/krb5routines.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/windows/leashdll/krb5routines.c b/src/windows/leashdll/krb5routines.c
index ff4f360..587f044 100644
--- a/src/windows/leashdll/krb5routines.c
+++ b/src/windows/leashdll/krb5routines.c
@@ -121,8 +121,8 @@ LeashKRB5_renew(void)
     code = pkrb5_get_renewed_creds(ctx, &my_creds, me, cc, NULL);
     pkrb5_cc_set_flags(ctx, cc, KRB5_TC_NOTICKET);
     if (code) {
-        if ( code != KRB5KDC_ERR_ETYPE_NOSUPP ||
-             code != KRB5_KDC_UNREACH)
+        if (code != KRB5KDC_ERR_ETYPE_NOSUPP && code != KRB5_KDC_UNREACH &&
+            code != KRB5_CC_NOTFOUND)
             Leash_krb5_error(code, "krb5_get_renewed_creds()", 0, &ctx, &cc);
         goto cleanup;
     }
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.