krb5 commit: Remove unnecessary flag in macOS build

Greg Hudson <[email protected]>
Newsgroups gmane.comp.encryption.kerberos.cvs
Message-ID <[email protected]>
https://github.com/krb5/krb5/commit/3c66c1fec7ce4edeff284a5e4abe32d0b4398539
commit 3c66c1fec7ce4edeff284a5e4abe32d0b4398539
Author: Nikhil Benesch <[email protected]>
Date:   Wed Dec 22 18:58:17 2021 -0500

    Remove unnecessary flag in macOS build
    
    The configuration logic for adding the `-search_paths_first` linker
    flag on Darwin does not correctly handle cross compilation.  It should
    check the value of $krb5_cv_host rather than `uname -s` to detect when
    the compilation target is Darwin, rather than the build machine.
    
    It turns out `-search_paths_first` has been the default behavior of ld
    on macOS since XCode 4.  So just remove that bit of logic entirely.
    (The flag was added in commit acd27af0e845f8b93de2e226cc2ec9ac8af52077
    in 2004; XCode 4 was released in 2010.)
    
    [[email protected]: edited commit message]

 src/aclocal.m4 |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/src/aclocal.m4 b/src/aclocal.m4
index 0ea4d18..9920476 100644
--- a/src/aclocal.m4
+++ b/src/aclocal.m4
@@ -595,10 +595,6 @@ if test "$GCC" = yes ; then
       CFLAGS="$CFLAGS -fno-common"
       ;;
     esac
-    case "$LD $LDFLAGS" in
-    *-Wl,-search_paths_first*) ;;
-    *) LDFLAGS="${LDFLAGS} -Wl,-search_paths_first" ;;
-    esac
   fi
 else
   if test "`uname -s`" = AIX ; then
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.