[openssl/openssl] 53eea2: statem: fix missing fatal if valid_flags mfail in ...
"'Jakub Zelenka' via openssl-commits" <[email protected]>
| Newsgroups | gmane.comp.encryption.openssl.cvs |
|---|---|
| Message-ID | <openssl/openssl/push/refs/heads/openssl-3.4/[email protected]> |
Branch: refs/heads/openssl-3.4
Home: https://github.com/openssl/openssl
Commit: 53eea20f5608e42402edd2df8a6abb08d373ee7f
https://github.com/openssl/openssl/commit/53eea20f5608e42402edd2df8a6abb08d373ee7f
Author: Jakub Zelenka <[email protected]>
Date: 2026-06-03 (Wed, 03 Jun 2026)
Changed paths:
M ssl/statem/statem_clnt.c
Log Message:
-----------
statem: fix missing fatal if valid_flags mfail in process cert req
It is a contract of tls process functions to trigger fatal error if they
fail. This is not being done in checking result of s->s3.tmp.valid_flags
allocation. If this happens, it triggers alert in read_state_machine()
for READ_STATE_BODY state that calls this process function. It calls
check_fatal() if MSG_PROCESS_ERROR is returned and the assert in it
fails because no error is triggered.
The fix just adds the fatal and also uses MSG_PROCESS_ERROR macro as
return value instead of hard coded 0.
Reviewed-by: Milan Broz <[email protected]>
Reviewed-by: Paul Yang <[email protected]>
MergeDate: Wed Jun 3 11:33:48 2026
(Merged from https://github.com/openssl/openssl/pull/31338)
To unsubscribe from these emails, change your notification settings at https://github.com/openssl/openssl/settings/notifications
--
You received this message because you are subscribed to the Google Groups "openssl-commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion visit https://groups.google.com/a/openssl.org/d/msgid/openssl-commits/openssl/openssl/push/refs/heads/openssl-3.4/67097b-53eea2%40github.com.