[openssl/openssl] fdd093: Use top to size BN add/sub results

  Branch: refs/heads/feature/ossl_fn
  Home:   https://github.com/openssl/openssl
  Commit: fdd0934158fc33cdfdf18b4971d590779dc6aad9
      https://github.com/openssl/openssl/commit/fdd0934158fc33cdfdf18b4971d590779dc6aad9
  Author: Richard Levitte <[email protected]>
  Date:   2026-06-11 (Thu, 11 Jun 2026)

  Changed paths:
    M crypto/bn/bn_add.c

  Log Message:
  -----------
  Use top to size BN add/sub results

Size the acquired result OSSL_FN from the significant operand limbs instead of
the allocated operand width. This keeps BN_uadd() and BN_usub() consistent
with the other wrappers that already use top for result sizing.

This follows a realization that applying OSSL_FN semantics onto BIGNUM too much
is pointless, and as demonstrated with BN_mul(), may be harmful, especially when
the result BIGNUM as the same as one of the operands.

Assisted-by: Pi:openai/gpt-5.5
Signed-off-by: Richard Levitte <[email protected]>

Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Igor Ustinov <[email protected]>
MergeDate: Fri Jun 12 15:16:33 2026
(Merged from https://github.com/openssl/openssl/pull/31448)


  Commit: c8edda8b2863fed9ebd71de1bee35700638553ff
      https://github.com/openssl/openssl/commit/c8edda8b2863fed9ebd71de1bee35700638553ff
  Author: Richard Levitte <[email protected]>
  Date:   2026-06-11 (Thu, 11 Jun 2026)

  Changed paths:
    M crypto/bn/bn_mul.c

  Log Message:
  -----------
  Acquire BN_mul result before ctx sizing

Acquire the writable result before reading operand dmax values for the
OSSL_FN_CTX arena size. This avoids stale context sizing when the result
aliases an operand and acquisition expands that BIGNUM.

Assisted-by: Pi:openai/gpt-5.5
Signed-off-by: Richard Levitte <[email protected]>

Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Igor Ustinov <[email protected]>
MergeDate: Fri Jun 12 15:16:34 2026
(Merged from https://github.com/openssl/openssl/pull/31448)


  Commit: 7190474bc7edf56c1d6f3d94059015991c9d18f1
      https://github.com/openssl/openssl/commit/7190474bc7edf56c1d6f3d94059015991c9d18f1
  Author: Richard Levitte <[email protected]>
  Date:   2026-06-11 (Thu, 11 Jun 2026)

  Changed paths:
    M crypto/bn/bn_sqr.c

  Log Message:
  -----------
  Acquire BN_sqr result before ctx sizing

Acquire the writable result before reading the operand dmax value for the
OSSL_FN_CTX arena size. This avoids stale context sizing when the result
aliases the operand and acquisition expands that BIGNUM.

Assisted-by: Pi:openai/gpt-5.5
Signed-off-by: Richard Levitte <[email protected]>

Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Igor Ustinov <[email protected]>
MergeDate: Fri Jun 12 15:16:36 2026
(Merged from https://github.com/openssl/openssl/pull/31448)


Compare: https://github.com/openssl/openssl/compare/f811a2894a94...7190474bc7ed

To unsubscribe from these emails, change your notification settings at https://github.com/openssl/openssl/settings/notifications

-- 
You received this message because you are subscribed to the Google Groups "openssl-commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion visit https://groups.google.com/a/openssl.org/d/msgid/openssl-commits/openssl/openssl/push/refs/heads/feature/ossl_fn/f811a2-719047%40github.com.