[openssl/openssl] 8c8a80: Extend refcounting on evp objects to provider requ...
"'Neil Horman' via openssl-commits" <[email protected]>
| Newsgroups | gmane.comp.encryption.openssl.cvs |
|---|---|
| Message-ID | <openssl/openssl/push/refs/heads/master/[email protected]> |
Branch: refs/heads/master
Home: https://github.com/openssl/openssl
Commit: 8c8a80b00ba1edb481838021568cdcd126386bff
https://github.com/openssl/openssl/commit/8c8a80b00ba1edb481838021568cdcd126386bff
Author: Neil Horman <[email protected]>
Date: 2026-07-02 (Thu, 02 Jul 2026)
Changed paths:
M crypto/core_fetch.c
M crypto/encode_decode/decoder_meth.c
M crypto/encode_decode/encoder_local.h
M crypto/encode_decode/encoder_meth.c
M crypto/evp/asymcipher.c
M crypto/evp/digest.c
M crypto/evp/evp_enc.c
M crypto/evp/evp_fetch.c
M crypto/evp/evp_lib.c
M crypto/evp/evp_local.h
M crypto/evp/evp_rand.c
M crypto/evp/exchange.c
M crypto/evp/kdf_meth.c
M crypto/evp/kem.c
M crypto/evp/keymgmt_meth.c
M crypto/evp/mac_meth.c
M crypto/evp/signature.c
M crypto/evp/skeymgmt_meth.c
M crypto/store/store_local.h
M crypto/store/store_meth.c
M include/crypto/decoder.h
M include/crypto/evp.h
M include/internal/core.h
M include/openssl/evp.h
M providers/implementations/storemgmt/file_store.c
M providers/implementations/storemgmt/winstore_store.c
Log Message:
-----------
Extend refcounting on evp objects to provider requesed no-caching
We recently removed reference counting for EVP objects, but kept the
refcounting when we build with no-cached-fetch.
There is a corner case in which providers in builds that do caching may
still request non-caching by setting *no_cache = 1 in their query
operations.
OQS tripped over this here:
https://github.com/open-quantum-safe/oqs-provider/pull/787
When a provider requests no caching, we need to treat those algorithms
as though we are running in a no-cached-fetch build and still do ref
counting on them.
Teach our algorithms implementation to understand when a provider is
requesting non-caching, mark them as such and ref count only those.
Reviewed-by: Milan Broz <[email protected]>
Reviewed-by: Dmitry Belyavskiy <[email protected]>
MergeDate: Thu Jul 2 14:24:13 2026
(Merged from https://github.com/openssl/openssl/pull/31782)
Commit: a66d74c8c18ed54ad9c95617959cc0b32e508398
https://github.com/openssl/openssl/commit/a66d74c8c18ed54ad9c95617959cc0b32e508398
Author: Neil Horman <[email protected]>
Date: 2026-07-02 (Thu, 02 Jul 2026)
Changed paths:
M test/p_ossltest.c
Log Message:
-----------
add support to p_ossltest for non-cacheable fetches
Add the ability to direct p_ossltest to request no caching so that we
can test the provider driver non-cache code path.
Reviewed-by: Milan Broz <[email protected]>
Reviewed-by: Dmitry Belyavskiy <[email protected]>
MergeDate: Thu Jul 2 14:24:15 2026
(Merged from https://github.com/openssl/openssl/pull/31782)
Commit: cf82f5f78f57f56de49a5f346aea6a4baf020c7c
https://github.com/openssl/openssl/commit/cf82f5f78f57f56de49a5f346aea6a4baf020c7c
Author: Neil Horman <[email protected]>
Date: 2026-07-02 (Thu, 02 Jul 2026)
Changed paths:
A test/recipes/30-test_evp_list_noncache.t
Log Message:
-----------
Add test to exercise non-caching code paths
Use openssl list, which uses EVP_*_do_all_provided on non-caching
algorithms. The do_all_provided path callbacks expect the algorithms
that are looked up to be saveable via up_ref, so this, when run under
asan, makes for a good test to ensure we don't trigger any use after
free situations when not caching algs.
Reviewed-by: Milan Broz <[email protected]>
Reviewed-by: Dmitry Belyavskiy <[email protected]>
MergeDate: Thu Jul 2 14:24:17 2026
(Merged from https://github.com/openssl/openssl/pull/31782)
Compare: https://github.com/openssl/openssl/compare/a3b7e0911492...cf82f5f78f57
To unsubscribe from these emails, change your notification settings at https://github.com/openssl/openssl/settings/notifications
--
You received this message because you are subscribed to the Google Groups "openssl-commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion visit https://groups.google.com/a/openssl.org/d/msgid/openssl-commits/openssl/openssl/push/refs/heads/master/a3b7e0-cf82f5%40github.com.