[openssl/openssl] 88cdff: ssl: Remove shadowed variable in write retry path
"'Mounir IDRASSI' via openssl-commits" <[email protected]> Mon, 03 Aug 2026 08:59:35 -0700
| Newsgroups | gmane.comp.encryption.openssl.cvs |
|---|---|
| Message-ID | <openssl/openssl/push/refs/heads/openssl-3.5/[email protected]> |
Branch: refs/heads/openssl-3.5
Home: https://github.com/openssl/openssl
Commit: 88cdff90e4af0f0b6732ba4bb395b0e8a831edb7
https://github.com/openssl/openssl/commit/88cdff90e4af0f0b6732ba4bb395b0e8a831edb7
Author: Mounir IDRASSI <[email protected]>
Date: 2026-08-03 (Mon, 03 Aug 2026)
Changed paths:
M ssl/record/methods/tls_common.c
Log Message:
-----------
ssl: Remove shadowed variable in write retry path
Commit 8d46334ee4ef "Fix false success on zero BIO write" introduced
a function-scope left variable while the app-buffer recovery block
already declared one. This breaks builds using -Werror=shadow.
Assign the current buffer length to the existing function-scope variable
in the recovery block. This preserves the previous re-read at that point
while eliminating the shadowed declaration.
Fixes: 8d46334ee4ef "Fix false success on zero BIO write"
Reviewed-by: Viktor Dukhovni <[email protected]>
Reviewed-by: Andrew Dinh <[email protected]>
Reviewed-by: Jakub Zelenka <[email protected]>
Reviewed-by: Eugene Syromiatnikov <[email protected]>
MergeDate: Mon Aug 3 15:46:22 2026
(Merged from https://github.com/openssl/openssl/pull/32153)
(cherry picked from commit a2eea872d0af948e5b889083f248e270d7326be7)
To unsubscribe from these emails, change your notification settings at https://github.com/openssl/openssl/settings/notifications
--
You received this message because you are subscribed to the Google Groups "openssl-commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion visit https://groups.google.com/a/openssl.org/d/msgid/openssl-commits/openssl/openssl/push/refs/heads/openssl-3.5/8d4633-88cdff%40github.com.