[openssl/openssl] fc9a49: apps/tsget: switch WWW::Curl::Easy to Net::Curl::Easy

  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: fc9a497df11bcc1210ff640be072c06f927a8675
      https://github.com/openssl/openssl/commit/fc9a497df11bcc1210ff640be072c06f927a8675
  Author: Shreenidhi Shedi <[email protected]>
  Date:   2026-08-07 (Fri, 07 Aug 2026)

  Changed paths:
    M .github/workflows/ci.yml
    M CHANGES.md
    M apps/tsget.in

  Log Message:
  -----------
  apps/tsget: switch WWW::Curl::Easy to Net::Curl::Easy

Minimal module swap: replace WWW::Curl::Easy with Net::Curl::Easy.
Update callback signatures (Net::Curl passes the easy handle as the
first argument), replace error-code-based perform() with eval/die,
and drop cleanup() which Net::Curl does not require.

Assisted-by: Claude:claude-sonnet-4-6
Signed-off-by: Shreenidhi Shedi <[email protected]>

Reviewed-by: Andrew Dinh <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
MergeDate: Fri Aug  7 13:29:35 2026
(Merged from https://github.com/openssl/openssl/pull/31445)


  Commit: f9915f512c2fc5ce7c992a336dc5e9ca8e036236
      https://github.com/openssl/openssl/commit/f9915f512c2fc5ce7c992a336dc5e9ca8e036236
  Author: Shreenidhi Shedi <[email protected]>
  Date:   2026-08-07 (Fri, 07 Aug 2026)

  Changed paths:
    M apps/tsget.in

  Log Message:
  -----------
  apps/tsget: replace CURLOPT_UPLOAD with CURLOPT_POST

Switch from the UPLOAD+CUSTOMREQUEST+read-callback approach to
POSTFIELDS, eliminating the read_body/write_body callbacks and the
INFILE/INFILESIZE/FILE options. Rename get_timestamp to send_request
with a simpler interface that writes directly to the output file via
CURLOPT_WRITEDATA.

Assisted-by: Claude:claude-sonnet-4-6
Signed-off-by: Shreenidhi Shedi <[email protected]>

Reviewed-by: Andrew Dinh <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
MergeDate: Fri Aug  7 13:29:36 2026
(Merged from https://github.com/openssl/openssl/pull/31445)


  Commit: 2f6c5fc193e76395d373e485f27f8794d65b73f9
      https://github.com/openssl/openssl/commit/2f6c5fc193e76395d373e485f27f8794d65b73f9
  Author: Shreenidhi Shedi <[email protected]>
  Date:   2026-08-07 (Fri, 07 Aug 2026)

  Changed paths:
    M apps/tsget.in

  Log Message:
  -----------
  apps/tsget: enable use warnings

Add "use warnings" and wrap CURLOPT_RANDOM_FILE and CURLOPT_EGDSOCKET
setopt calls in eval blocks, as these constants were removed from
libcurl and would cause an exception on modern installations.

Assisted-by: Claude:claude-sonnet-4-6
Signed-off-by: Shreenidhi Shedi <[email protected]>

Reviewed-by: Andrew Dinh <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
MergeDate: Fri Aug  7 13:29:37 2026
(Merged from https://github.com/openssl/openssl/pull/31445)


  Commit: e9415c4fc64a42f57507e5edd5e2333dd018a465
      https://github.com/openssl/openssl/commit/e9415c4fc64a42f57507e5edd5e2333dd018a465
  Author: Shreenidhi Shedi <[email protected]>
  Date:   2026-08-07 (Fri, 07 Aug 2026)

  Changed paths:
    M apps/tsget.in

  Log Message:
  -----------
  apps/tsget: use three-arg open and binmode for binary safety

Switch bareword INPUT filehandle to a lexical filehandle with
three-argument open. Add binmode on both the STDIN and file paths
so timestamp request data is read as raw bytes on all platforms.

Assisted-by: Claude:claude-sonnet-4-6
Signed-off-by: Shreenidhi Shedi <[email protected]>

Reviewed-by: Andrew Dinh <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
MergeDate: Fri Aug  7 13:29:38 2026
(Merged from https://github.com/openssl/openssl/pull/31445)


  Commit: a96cd528dce1cb0caa378568e09aea18eaff7786
      https://github.com/openssl/openssl/commit/a96cd528dce1cb0caa378568e09aea18eaff7786
  Author: Shreenidhi Shedi <[email protected]>
  Date:   2026-08-07 (Fri, 07 Aug 2026)

  Changed paths:
    M apps/tsget.in

  Log Message:
  -----------
  apps/tsget: minor cleanups

Add a progress() helper to centralise verbose output. Move usage()
to the top. Rename @old_argv to @saved_argv. Replace foreach with
for+lexical variable. Inline $output_base. Switch exists to defined
for option checks. Remove the main-program comment block.

Assisted-by: Claude:claude-sonnet-4-6
Signed-off-by: Shreenidhi Shedi <[email protected]>

Reviewed-by: Andrew Dinh <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
MergeDate: Fri Aug  7 13:29:39 2026
(Merged from https://github.com/openssl/openssl/pull/31445)


  Commit: c1a710c7186c8dbadb9bba90ed5a3de35de1d39a
      https://github.com/openssl/openssl/commit/c1a710c7186c8dbadb9bba90ed5a3de35de1d39a
  Author: Shreenidhi Shedi <[email protected]>
  Date:   2026-08-07 (Fri, 07 Aug 2026)

  Changed paths:
    A test/recipes/80-test_tsget.t

  Log Message:
  -----------
  apps/tsget: add comprehensive test recipe

Adds test/recipes/80-test_tsget.t with 12 subtests covering:
- Default output extension (.tsr), custom extension (-e), custom output
  file (-o), stdin input, debug mode (-d), TSGET environment variable
- Multiple input files processed in one invocation
- Output path derived from input file's directory
- HTTP server error response: tsget exits non-zero and removes the
  partial output file
- Empty server response: same cleanup behaviour
- Argument validation: missing -h, multiple files combined with -o

Happy-path subtests use `openssl ts -verify` to confirm each response
is cryptographically valid against the TSA CA and signing certificate.

The mock HTTP server supports normal, error, and empty response modes
via keyword options so failure scenarios can be tested without a real
TSA endpoint.

Assisted-by: Claude:claude-sonnet-4-6
Signed-off-by: Shreenidhi Shedi <[email protected]>

Reviewed-by: Andrew Dinh <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
MergeDate: Fri Aug  7 13:29:41 2026
(Merged from https://github.com/openssl/openssl/pull/31445)


  Commit: 5268e1902ec1ddb7efe5dae0e556b3fb18a8e2a8
      https://github.com/openssl/openssl/commit/5268e1902ec1ddb7efe5dae0e556b3fb18a8e2a8
  Author: Shreenidhi Shedi <[email protected]>
  Date:   2026-08-07 (Fri, 07 Aug 2026)

  Changed paths:
    M doc/man1/tsget.pod

  Log Message:
  -----------
  Update tsget man page

Assisted-by: Claude:claude-sonnet-4-6
Signed-off-by: Shreenidhi Shedi <[email protected]>

Reviewed-by: Andrew Dinh <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
MergeDate: Fri Aug  7 13:29:42 2026
(Merged from https://github.com/openssl/openssl/pull/31445)


Compare: https://github.com/openssl/openssl/compare/def638aa2d68...5268e1902ec1

To unsubscribe from these emails, change your notification settings at https://github.com/openssl/openssl/settings/notifications

-- 
You received this message because you are subscribed to the Google Groups "openssl-commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion visit https://groups.google.com/a/openssl.org/d/msgid/openssl-commits/openssl/openssl/push/refs/heads/master/def638-5268e1%40github.com.