[openssl/openssl] 6b6982: ssl: restore missing SSLfatal in keylog output
"'Jakub Zelenka' via openssl-commits" <[email protected]>
| Newsgroups | gmane.comp.encryption.openssl.cvs |
|---|---|
| Message-ID | <openssl/openssl/push/refs/heads/openssl-4.0/[email protected]> |
Branch: refs/heads/openssl-4.0
Home: https://github.com/openssl/openssl
Commit: 6b6982ccca7f859b661787657fe7a74aeb0d9245
https://github.com/openssl/openssl/commit/6b6982ccca7f859b661787657fe7a74aeb0d9245
Author: Jakub Zelenka <[email protected]>
Date: 2026-08-27 (Thu, 27 Aug 2026)
Changed paths:
M ssl/ssl_lib.c
M ssl/tls13_enc.c
Log Message:
-----------
ssl: restore missing SSLfatal in keylog output
Commit e077455e9e dropped the SSLfatal() call together with the
ERR_R_MALLOC_FAILURE cleanup in nss_keylog_int(). Since then an
allocation failure there propagates a plain zero return through
ssl_log_secret() and ssl_log_rsa_client_key_exchange() callers whose
"SSLfatal() already called" comments no longer hold, tripping the
check_fatal assertion in the state machine on debug builds when a
keylog callback is set.
Commit 7d78cd722b papered over one symptom of this by calling SSLfatal()
directly at the early exporter secret call site in
tls13_change_cipher_state(). With the call restored at the source that
would now invoke SSLfatal() twice, pushing a duplicate entry on the
error queue, so revert that call site back to the
"SSLfatal() already called" comment used by all the other callers.
Assisted-by: Claude:claude-fable-5
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Frederik Wedel-Heinen <[email protected]>
Merge-date: Thu Aug 27 13:54:32 2026
Merged-from: https://github.com/openssl/openssl/pull/32196
(cherry picked from commit dde995f2913bf825bbd0e9c25af4c75caf917a10)
To unsubscribe from these emails, change your notification settings at https://github.com/openssl/openssl/settings/notifications
--
You received this message because you are subscribed to the Google Groups "openssl-commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion visit https://groups.google.com/a/openssl.org/d/msgid/openssl-commits/openssl/openssl/push/refs/heads/openssl-4.0/512483-6b6982%40github.com.