[openssl/openssl] 0f31f6: test: fix TAP stream corruption in three test recipes
"'Richard Levitte' via openssl-commits" <[email protected]>
| Newsgroups | gmane.comp.encryption.openssl.cvs |
|---|---|
| Message-ID | <openssl/openssl/push/refs/heads/openssl-3.6/[email protected]> |
Branch: refs/heads/openssl-3.6
Home: https://github.com/openssl/openssl
Commit: 0f31f694cf61a5154023688c5dcc86ca09b277d2
https://github.com/openssl/openssl/commit/0f31f694cf61a5154023688c5dcc86ca09b277d2
Author: Richard Levitte <[email protected]>
Date: 2026-08-27 (Thu, 27 Aug 2026)
Changed paths:
M test/recipes/15-test_ml_dsa_codecs.t
M test/recipes/15-test_ml_kem_codecs.t
M test/recipes/20-test_pkeyutl.t
Log Message:
-----------
test: fix TAP stream corruption in three test recipes
'local $/ = undef' leaks into OpenSSL::Test::run(), which then
emits a bare "# " that glues onto the following 'ok' line.
Scope the slurping properly.
'pkeyutl -verifyrecover' outputs binary on stdout; redirect it.
Fixes: https://github.com/openssl/openssl/issues/32428
Assisted-by: Pi:moonshotai/kimi-k3
Signed-off-by: Richard Levitte <[email protected]>
Reviewed-by: Mounir Idrassi <[email protected]>
Reviewed-by: Nikola Pajkovsky <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
Merge-date: Thu Aug 27 14:20:32 2026
Merged-from: https://github.com/openssl/openssl/pull/32429
(cherry picked from commit 936250eef1c319c905af85639dcc2e3f67712f94)
Commit: 9f919186c2d06afa8a185dfaa6f833656fdf3c03
https://github.com/openssl/openssl/commit/9f919186c2d06afa8a185dfaa6f833656fdf3c03
Author: Richard Levitte <[email protected]>
Date: 2026-08-27 (Thu, 27 Aug 2026)
Changed paths:
M util/perl/OpenSSL/Test.pm
Log Message:
-----------
test framework: always read child output line by line in run()
If a recipe played with $/ (slurp or paragraph mode), the pipe read
would misbehave and emit a bare "# " prefix, or prefix only the
first line of a multi-line read, risking TAP stream corruption.
Fixes: https://github.com/openssl/openssl/issues/32428
Assisted-by: Pi:moonshotai/kimi-k3
Signed-off-by: Richard Levitte <[email protected]>
Reviewed-by: Mounir Idrassi <[email protected]>
Reviewed-by: Nikola Pajkovsky <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
Merge-date: Thu Aug 27 14:20:36 2026
Merged-from: https://github.com/openssl/openssl/pull/32429
(cherry picked from commit 4fb28c19f5e2e9b9139c603b224a7142996f7ada)
Compare: https://github.com/openssl/openssl/compare/abb4a4d7a1c6...9f919186c2d0
To unsubscribe from these emails, change your notification settings at https://github.com/openssl/openssl/settings/notifications
--
You received this message because you are subscribed to the Google Groups "openssl-commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion visit https://groups.google.com/a/openssl.org/d/msgid/openssl-commits/openssl/openssl/push/refs/heads/openssl-3.6/abb4a4-9f9191%40github.com.