[openssl/openssl] a8b17c: test: fix TAP stream corruption in three test recipes

"'Richard Levitte' via openssl-commits" <[email protected]>
Newsgroups gmane.comp.encryption.openssl.cvs
Message-ID <openssl/openssl/push/refs/heads/openssl-4.0/[email protected]>
  Branch: refs/heads/openssl-4.0
  Home:   https://github.com/openssl/openssl
  Commit: a8b17c702b6a5bb48a87c1e73dfd4257f51e08fd
      https://github.com/openssl/openssl/commit/a8b17c702b6a5bb48a87c1e73dfd4257f51e08fd
  Author: Richard Levitte <[email protected]>
  Date:   2026-08-27 (Thu, 27 Aug 2026)

  Changed paths:
    M test/recipes/15-test_ml_dsa_codecs.t
    M test/recipes/15-test_ml_kem_codecs.t
    M test/recipes/20-test_pkeyutl.t

  Log Message:
  -----------
  test: fix TAP stream corruption in three test recipes

'local $/ = undef' leaks into OpenSSL::Test::run(), which then
emits a bare "# " that glues onto the following 'ok' line.
Scope the slurping properly.

'pkeyutl -verifyrecover' outputs binary on stdout; redirect it.

Fixes: https://github.com/openssl/openssl/issues/32428
Assisted-by: Pi:moonshotai/kimi-k3
Signed-off-by: Richard Levitte <[email protected]>
Reviewed-by: Mounir Idrassi <[email protected]>
Reviewed-by: Nikola Pajkovsky <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
Merge-date: Thu Aug 27 14:20:32 2026
Merged-from: https://github.com/openssl/openssl/pull/32429
(cherry picked from commit 936250eef1c319c905af85639dcc2e3f67712f94)


  Commit: 93591456febeaefae3ea0d6ff4843d45306fb65d
      https://github.com/openssl/openssl/commit/93591456febeaefae3ea0d6ff4843d45306fb65d
  Author: Richard Levitte <[email protected]>
  Date:   2026-08-27 (Thu, 27 Aug 2026)

  Changed paths:
    M util/perl/OpenSSL/Test.pm

  Log Message:
  -----------
  test framework: always read child output line by line in run()

If a recipe played with $/ (slurp or paragraph mode), the pipe read
would misbehave and emit a bare "# " prefix, or prefix only the
first line of a multi-line read, risking TAP stream corruption.

Fixes: https://github.com/openssl/openssl/issues/32428
Assisted-by: Pi:moonshotai/kimi-k3
Signed-off-by: Richard Levitte <[email protected]>
Reviewed-by: Mounir Idrassi <[email protected]>
Reviewed-by: Nikola Pajkovsky <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
Merge-date: Thu Aug 27 14:20:36 2026
Merged-from: https://github.com/openssl/openssl/pull/32429
(cherry picked from commit 4fb28c19f5e2e9b9139c603b224a7142996f7ada)


Compare: https://github.com/openssl/openssl/compare/6b6982ccca7f...93591456febe

To unsubscribe from these emails, change your notification settings at https://github.com/openssl/openssl/settings/notifications

-- 
You received this message because you are subscribed to the Google Groups "openssl-commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion visit https://groups.google.com/a/openssl.org/d/msgid/openssl-commits/openssl/openssl/push/refs/heads/openssl-4.0/6b6982-935914%40github.com.
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.