Re: [bug report 2/8] Implement seed/key preference when decoding

Viktor Dukhovni <[email protected]> Wed, 15 Apr 2026 04:23:09 +1000
Newsgroups gmane.comp.encryption.openssl.user
Message-ID <[email protected]>
On Fri, Apr 10, 2026 at 08:14:32PM +0300, Dan Carpenter wrote:

> Commit 5b2d996f9145 ("Implement seed/key preference when decoding")
> from Jan 28, 2025 (linux-next), leads to the following Smatch static
> checker warning:
>=20
> 	providers/implementations/encode_decode/ml_kem_codecs.c:423 ossl_ml_kem_=
i2d_pubkey()
> 	error: we previously assumed 'out' could be null (see line 420)

In fact the internall caller must and never does pass NULL, the check is
redundant.  The check can be dropped.

--=20
    Viktor.  =F0=9F=87=BA=F0=9F=87=A6 =D0=A1=D0=BB=D0=B0=D0=B2=D0=B0 =D0=A3=
=D0=BA=D1=80=D0=B0=D1=97=D0=BD=D1=96!

--=20
You received this message because you are subscribed to the Google Groups "=
openssl-users" group.
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to openssl-users+unsubscribe-MCmKBN63+Bmbup2nOX2J7Q@public.gmane.org
To view this discussion visit https://groups.google.com/a/openssl.org/d/msg=
id/openssl-users/ad6GDQEWKRtpcG5h%40chardros.imrryr.org.