Re: Patches to get Arla running on FreeBSD 8-CURRENT

On 2008-02-23 04:29, Alec wrote:
> 
> #define HAVE_KERNEL_INSMNTQUE 1 
> 
> in it.  I'll add it to my list of configure-related issues.
> Recompiling now...
> 

oldothello% uname -a
FreeBSD oldothello.setfilepointer.com 8.0-CURRENT FreeBSD 8.0-CURRENT #0: Wed Feb 20 13:45:22 CST 2008 [email protected]:/usr/local/obj/usr/src/sys/GENERIC
i386
oldothello% ls /afs
andrew.cmu.edu      grand.central.org   openafs.org
athena.mit.edu      hallf.kth.se        research.company.com
cern.ch         isk.kth.se      rose-hulman.edu
deek.org        it.kth.se       setfilepointer.com
dementia.org        md.kth.se       stacken.kth.se
dev.mit.edu     mech.kth.se
e.kth.se        mekinok.com
oldothello%

Neat!  Heimdal gets tokens correctly, access to private directories
works.  I'm running the arla test suite now;  I'm up to hardlink3
with no problems.  I did notice that, when umounting /afs, I get
a lock order reversal:

lock order reversal:
 1st 0xc231329c vfslock (vfslock) @ /usr/src/sys/kern/vfs_mount.c:1242
 2nd 0xc2dabaf8 syncer (syncer) @ /usr/src/sys/kern/vfs_subr.c:2156
KDB: stack backtrace:
db_trace_self_wrapper(c0af1b78,cd4b3b2c,c07a1a6e,c0af3fc2,c2dabaf8,...) at db_trace_self_wrapper+0x26
kdb_backtrace(c0af3fc2,c2dabaf8,c0afad01,c0afad01,c0afa47c,...) at kdb_backtrace+0x29
witness_checkorder(c2dabaf8,9,c0afa47c,86c,c0c16cb4,...) at witness_checkorder+0x6de
_lockmgr(c2dabaf8,2002,c2dabb28,c0afa47c,86c,...) at _lockmgr+0x43c
vop_stdlock(cd4b3bc4,c0afa47c,c07a1338,2002,c2dabaa0,...) at vop_stdlock+0x39
VOP_LOCK1_APV(c0bb0980,cd4b3bc4,84f,cd4b3be4,c2dabb28,...) at VOP_LOCK1_APV+0xa5
_vn_lock(c2dabaa0,2002,c0afa47c,86c,0,...) at _vn_lock+0xf2
vrele(c2dabaa0,0,c0af9de1,4f0,4da,...) at vrele+0x142
dounmount(c231329c,8000000,c356b000,482,8,...) at dounmount+0x372
unmount(c356b000,cd4b3cfc,8,cd4b3d38,c0ba0ed0,...) at unmount+0x2e0
syscall(cd4b3d38) at syscall+0x2b3
Xint0x80_syscall() at Xint0x80_syscall+0x20
--- syscall (22, FreeBSD ELF32, unmount), eip = 0x280c62db, esp =
0xbfbfe4ec, ebp = 0xbfbfe5a8 ---

I see a few other lock order reversals on -CURRENT right now
anyway, so I'm not sure if it's cause for concern or even caused
by arla.

I'm going to move on to trying everything on 7.x.  I know there are
autoconf/etc. things that need to be fixed.  Do you want me to work
on that or are you likely to have it done already.  
I do have a tweaked version of your patch---as I recall it contains
just one typo fix---at

	http://setfilepointer.com/pub/arla/20080218-arla.diff

There's also the snapshot of the sources I used:

	http://setfilepointer.com/pub/arla/arla-20080118.tar.bz2

Assuming I get things working on 7.x, I'll update the port I built
later today.  :)

-- 
Alec Kloss  [email protected]   IM: [email protected]
PGP key at http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xA241980E
"No Bunny!" -- Simon, from Frisky Dingo

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (FreeBSD)

iD8DBQFHv/4N2s33paJBmA4RAi6LAJ9YEJqJTVrsniYHJSXqobrc74FNmgCfeMEK
Z70j7rSLRbPpLavjfbKV4KA=
=RDi8
-----END PGP SIGNATURE-----